Bug 124768

Summary: [curl] Fix of SSL certificate chain storage
Product: WebKit Reporter: sipka
Component: WebKit Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, galpeter
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 117300    
Attachments:
Description Flags
proposed patch
none
proposed patch none

Description sipka 2013-11-22 04:46:06 PST 
Change the certificates storage type into ListHashSet from HashSet to keep the chain order in each case. 
This ensures that there is no difference between the stored and the recieved certificate chain.
Comment 1 sipka 2013-11-22 04:49:36 PST 
Created attachment 217669 [details]
proposed patch
Comment 2 WebKit Commit Bot 2013-11-22 04:51:35 PST 
Attachment 217669 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/network/curl/SSLHandle.cpp']" exit_code: 1
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 sipka 2013-11-22 04:53:47 PST 
Created attachment 217670 [details]
proposed patch

Add missing bug url.
Comment 4 Brent Fulgham 2013-11-22 08:57:02 PST 
Comment on attachment 217670 [details]
proposed patch

r=me
Comment 5 WebKit Commit Bot 2013-11-22 09:25:32 PST 
Comment on attachment 217670 [details]
proposed patch

Clearing flags on attachment: 217670

Committed r159692: <http://trac.webkit.org/changeset/159692>
Comment 6 WebKit Commit Bot 2013-11-22 09:25:34 PST 
All reviewed patches have been landed.  Closing bug.