Bug 124757

Summary: ASSERT_WITH_SECURITY_IMPLICATION should crash in a distinct way
Product: WebKit Reporter: Drew Yao <ayao>
Component: Web Template FrameworkAssignee: Drew Yao <ayao>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Drew Yao
Reported 2013-11-21 18:50:04 PST
ASSERT_WITH_SECURITY_IMPLICATION currently calls CRASH(). There are many other non security related code paths that call CRASH(). ASSERT_WITH_SECURITY_IMPLICATION should crash in a distinct way in order to help screen fuzzing bugs. The attached patch adds a CRASH_WITH_SECURITY_IMPLICATION which is the same as CRASH except it accesses 0xfbadbeef instead of 0xbbadbeef. The same as before, in release builds, ASSERT_WITH_SECURITY_IMPLICATION will do nothing unless it was built with ASAN, which required moving the code around a little, since before it just called ASSERT() when ASAN was not defined.
Attachments
Patch (3.33 KB, patch)
2013-11-21 18:54 PST, Drew Yao 		no flags
DetailsFormatted DiffDiff
Patch (3.34 KB, patch)
2013-11-21 19:10 PST, Drew Yao 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Drew Yao
Comment 1 2013-11-21 18:54:01 PST
Created attachment 217641 [details] Patch
WebKit Commit Bot
Comment 2 2013-11-21 18:55:58 PST
Attachment 217641 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Assertions.cpp', u'Source/WTF/wtf/Assertions.h']" exit_code: 1 Source/WTF/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Source/WTF/ChangeLog:7: Line contains tab character. [whitespace/tab] [5] Source/WTF/wtf/Assertions.h:238: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/Assertions.h:279: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 4 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Drew Yao
Comment 3 2013-11-21 19:10:05 PST
Created attachment 217643 [details] Patch
Drew Yao
Comment 4 2013-11-21 19:11:19 PST
I updated the patch to fix the whitespace issues in the ChangeLog. Re: the whitespace issues in Assertions.h, the whitespace I used is exactly the same as was already used for the existing code.
WebKit Commit Bot
Comment 5 2013-11-21 19:11:20 PST
Attachment 217643 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/Assertions.cpp', u'Source/WTF/wtf/Assertions.h']" exit_code: 1 Source/WTF/wtf/Assertions.h:238: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WTF/wtf/Assertions.h:279: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brent Fulgham
Comment 6 2013-11-26 19:05:20 PST
Comment on attachment 217643 [details] Patch r=me
WebKit Commit Bot
Comment 7 2013-11-26 19:32:37 PST
Comment on attachment 217643 [details] Patch Clearing flags on attachment: 217643 Committed r159799: <http://trac.webkit.org/changeset/159799>
WebKit Commit Bot
Comment 8 2013-11-26 19:32:39 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.