Bug 124745

Summary: Add a setting to opt into a mode where the background extends and fixed elements don't move on rubber-band
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: Layout and RenderingAssignee: Beth Dakin <bdakin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, commit-queue, eflews.bot, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan, sam, simon.fraser, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch thorton: review+, eflews.bot: commit-queue-

Description Beth Dakin 2013-11-21 14:17:30 PST 
We should add a setting to opt into a mode where the tile cache has a margin and fixed elements don't move on rubber-band. In other words, this setting would enable a way to opt into the work done in these bugs: https://bugs.webkit.org/show_bug.cgi?id=124260 http://bugs.webkit.org/show_bug.cgi?id=124216
Comment 1 Beth Dakin 2013-11-21 14:26:42 PST 
Created attachment 217614 [details]
Patch
Comment 2 WebKit Commit Bot 2013-11-21 14:29:28 PST 
Attachment 217614 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/Settings.in', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebKit/ChangeLog', u'Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/WebPreferencesStore.h', u'Source/WebKit2/UIProcess/API/C/WKPreferences.cpp', u'Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp']" exit_code: 1
Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:462:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Beth Dakin 2013-11-21 14:33:46 PST 
Created attachment 217616 [details]
Patch
Comment 4 EFL EWS Bot 2013-11-21 15:17:49 PST 
Comment on attachment 217616 [details]
Patch

Attachment 217616 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/33018009
Comment 5 Tim Horton 2013-11-22 09:47:18 PST 
Comment on attachment 217616 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217616&action=review

EFL error is "c++: internal compiler error: Killed (program cc1plus)" so we don't care.

> Source/WebCore/page/Settings.in:216
> +backgroundShouldExtendBeyondPage initial=false, setNeedsStyleRecalcInAllFrames=1

Do you need the style recalc? Are we intending for this to be switchable, live? I don't think it will be as it stands, so maybe you don't need this either.
Comment 6 Beth Dakin 2013-12-02 13:50:56 PST 
Thanks, Tim! http://trac.webkit.org/changeset/159960