Bug 124728

Summary: Ensure future layouts use the correct linebox layout path when adding a float
Product: WebKit Reporter: Robert Hogan <robert>
Component: Layout and RenderingAssignee: Robert Hogan <robert>
Status: RESOLVED INVALID    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, koivisto, kondapallykalyan, robert
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Robert Hogan
Reported 2013-11-21 11:26:46 PST
When adding a float to an object the simple linebox layout path won't work for it anymore, so ensure it checks again which layout path to use.
Attachments
Patch (3.61 KB, patch)
2013-11-21 11:31 PST, Robert Hogan 		no flags
DetailsFormatted DiffDiff
Patch (1.76 KB, patch)
2013-11-21 11:34 PST, Robert Hogan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Robert Hogan
Comment 1 2013-11-21 11:31:56 PST
Created attachment 217586 [details] Patch
Robert Hogan
Comment 2 2013-11-21 11:34:52 PST
Created attachment 217588 [details] Patch
Robert Hogan
Comment 3 2013-11-21 11:47:16 PST
Hi Antti, After updating trunk to upload this patch it looks like the regression I caused in r159575 was fixed by r159579 - simple line layout now supports floats so there's nothing to worry about anymore.
Csaba Osztrogonác
Comment 4 2014-02-13 03:46:20 PST
Comment on attachment 217588 [details] Patch Cleared review? from attachment 217588 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.