Bug 124719

Summary:

Remove codecs and os dependencies from filereader.py in webkitpy/style.

Product:

WebKit

Reporter:

László Langó <llango.u-szeged>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, bfulgham, commit-queue, glenn, ossy, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

László Langó

Reported 2013-11-21 08:20:09 PST

Although TextFileReader requires a FileSystem it circumvents it in two places! We should use the FileSystem only and remove codecs and os imports.

Attachments
Patch (3.99 KB, patch) 2013-11-21 08:25 PST, László Langó	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

László Langó

Comment 1 2013-11-21 08:25:58 PST

Created attachment 217573 [details] Patch

Peter Gal

Comment 2 2013-11-29 05:43:46 PST

Comment on attachment 217573 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217573&action=review > Tools/Scripts/webkitpy/style/filereader.py:129 > + for file_path in self.filesystem.files_under(directory): > + self.process_file(file_path) IMHO this is a different modification and not related to this bug report.

Peter Gal

Comment 3 2013-11-29 05:54:29 PST

Comment on attachment 217573 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217573&action=review >> Tools/Scripts/webkitpy/style/filereader.py:129 >> + self.process_file(file_path) > > IMHO this is a different modification and not related to this bug report. Ah.. my mistake didn't saw the os.walk there. :)

Zoltan Herczeg

Comment 4 2013-12-04 02:48:04 PST

Comment on attachment 217573 [details] Patch r=me

WebKit Commit Bot

Comment 5 2013-12-04 03:17:06 PST

Comment on attachment 217573 [details] Patch Clearing flags on attachment: 217573 Committed r160085: <http://trac.webkit.org/changeset/160085>

WebKit Commit Bot

Comment 6 2013-12-04 03:17:08 PST

All reviewed patches have been landed. Closing bug.

Alexey Proskuryakov

Comment 7 2014-01-13 00:08:36 PST

check-webkit-style now fails with a decode error on patches that include new PNG files. This is tracked as bug 126702. Could you please look into it?

László Langó

Comment 8 2014-01-13 00:15:29 PST

(In reply to comment #7) > check-webkit-style now fails with a decode error on patches that include new PNG files. > > This is tracked as bug 126702. Could you please look into it? It sounds really strange. I'll see what can i do. I'll fix it asap.

Note You need to log in before you can comment on or make changes to this bug.