Bug 124697

Summary: REGRESSION(r159599): webkitdirs.pm spits out warnings at lines 851 and 852
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dbates, eocanha, nick.diego, rego
Priority: P1 Keywords: Regression
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 124581    
Attachments:
Description Flags
Patch none

Ryosuke Niwa
Reported 2013-11-20 22:06:24 PST
After http://trac.webkit.org/changeset/159599, I'm getting errors like the one below everywhere: server:git-webkit rniwa$ Tools/Scripts/run-webkit-tests --debug LayoutTests/fast/dom LayoutTests/fast/html LayoutTests/fast/forms LayoutTests/svg LayoutTests/html5lib/ Use of uninitialized value in splice at /Volumes/Data/git-webkit/Tools/Scripts/webkitdirs.pm line 851. Use of uninitialized value in splice at /Volumes/Data/git-webkit/Tools/Scripts/webkitdirs.pm line 852. Use of uninitialized value in splice at /Volumes/Data/git-webkit/Tools/Scripts/webkitdirs.pm line 851. Use of uninitialized value in splice at /Volumes/Data/git-webkit/Tools/Scripts/webkitdirs.pm line 852. Use of uninitialized value in splice at /Volumes/Data/git-webkit/Tools/Scripts/webkitdirs.pm line 851. Use of uninitialized value in splice at /Volumes/Data/git-webkit/Tools/Scripts/webkitdirs.pm line 852. Use of uninitialized value in splice at /Volumes/Data/git-webkit/Tools/Scripts/webkitdirs.pm line 851. Use of uninitialized value in splice at /Volumes/Data/git-webkit/Tools/Scripts/webkitdirs.pm line 852. Use of uninitialized value in splice at /Volumes/Data/git-webkit/Tools/Scripts/webkitdirs.pm line 851. Use of uninitialized value in splice at /Volumes/Data/git-webkit/Tools/Scripts/webkitdirs.pm line 852. Use of uninitialized value in splice at /Volumes/Data/git-webkit/Tools/Scripts/webkitdirs.pm line 851. Use of uninitialized value in splice at /Volumes/Data/git-webkit/Tools/Scripts/webkitdirs.pm line 852. We're also seeing them on various builders on build.webkit.org. Please fix it ASAP.
Attachments
Patch (1.35 KB, patch)
2013-11-21 03:34 PST, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2013-11-21 01:55:43 PST
BTW, this causes that Tools/Scripts/run-launcher ignores the arguments at least in GTK+ port. For example the following case will ignore the URL: Tools/Scripts/run-launcher --gtk http://www.webkit.org
Manuel Rego Casasnovas
Comment 2 2013-11-21 03:34:36 PST
Created attachment 217543 [details] Patch This fix the warnings for me. It was trying to access to first element of an array when array has 0 elements.
WebKit Commit Bot
Comment 3 2013-11-21 04:23:42 PST
Comment on attachment 217543 [details] Patch Clearing flags on attachment: 217543 Committed r159616: <http://trac.webkit.org/changeset/159616>
WebKit Commit Bot
Comment 4 2013-11-21 04:23:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.