Bug 12465

Summary: REGRESSION: favicon.ico looked for on port 0
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Page LoadingAssignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, ddkilzer, mrowe
Priority: P1 Keywords: EasyFix, Regression
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
URL: http://www.google.com
Attachments:
Description Flags
Patch oliver: review+

Alexey Proskuryakov
Reported 2007-01-29 12:39:16 PST
After the fix for bug 11085, most favicons are looked for at port 0. Steps to reproduce: open www.google.com, open Activity window, check the entry for favicon.ico.
Attachments
Patch (975 bytes, patch)
2007-01-29 14:11 PST, Brady Eidson 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 2007-01-29 14:01:10 PST
We should special-case port number of 0 as no port, since a URL will never validly have a portn number of 0.
Brady Eidson
Comment 2 2007-01-29 14:11:14 PST
Created attachment 12757 [details] Patch
Oliver Hunt
Comment 3 2007-01-29 14:15:56 PST
Comment on attachment 12757 [details] Patch indentation appears to be borken, but otherwise r=me
Brady Eidson
Comment 4 2007-01-29 14:20:31 PST
r19235
Note You need to log in before you can comment on or make changes to this bug.