Bug 124628
| Summary: | [EFL][CMAKE] Configuration is failed with EFL 1.8 on CMake lower than 2.8.8 after r159496 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryuan Choi <ryuan.choi> |
| Component: | WebKit EFL | Assignee: | Ryuan Choi <ryuan.choi> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | Normal | CC: | gyuyoung.kim, lucas.de.marchi, seokju |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 124555 | ||
Ryuan Choi
r159496 tried to use config mode of find_package() for EFL 1.8 because EFL 1.8 provides FooConfig.cmake.
But, config mode of find_package() is supported from CMake 2.8.8.
So, CMake generates error in lower versions.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Gyuyoung Kim
(In reply to comment #0)
> r159496 tried to use config mode of find_package() for EFL 1.8 because EFL 1.8 provides FooConfig.cmake.
>
> But, config mode of find_package() is supported from CMake 2.8.8.
Though I use cmake 2.8.10 ver., there is below warning since r159496.
CMake Warning at Source/cmake/OptionsEfl.cmake:126 (find_package):
Could not find a package configuration file provided by "Eo" with any of
the following names:
EoConfig.cmake
eo-config.cmake
Add the installation prefix of "Eo" to CMAKE_PREFIX_PATH or set "Eo_DIR" to
a directory containing one of the above files. If "Eo" provides a separate
development package or SDK, be sure it has been installed.
Call Stack (most recent call first):
CMakeLists.txt:137 (include)
Gyuyoung Kim
It looks you should fix two problems, one is build break on lower cmake version, and other is build warning. How about rolling it out for now ?
Ryuan Choi
124555 should cover this.