Bug 124613 – Web Inspector: Push Remote Inspector debugging connection management into JavaScriptCore

• Component: Web Inspector
• Status: RESOLVED FIXED

[Joseph Pecoraro]

In order to make a JSContext a remote debug target, like a WebKit1 WebView is right now, we would need to make it possible to set up a Remote Inspector connection (ENABLE(REMOTE_INSPECTOR)) to an application that only links JavaScriptCore.framework (containing JSContext). To make this possible, we should move the ENABLE(REMOTE_INSPECTOR) remote debugging connection management that currently exists in WebKit/mac down into JavaScriptCore.

At the same time we can improve it:

    • allow for different types of remote debuggable targets, e.g. a JSContext, WebView, WKView
    • allow debuggables to be registered and debugged on any thread, unlike WebViews, JSContexts may be run entirely off of the main thread.
    • move the remote connection (XPC connection) itself off of the main thread, it doesn't need to be on the main thread.

Note: Part of this bug will include removing the old WebKit1 implementation and replacing it with this new implementation. So that will imply either removing or replacing the existing SPI (Private API) with something similar / compatible.

[Joseph Pecoraro]

Created attachment 217350 [details]
[PATCH] Part 1 - JSC remote inspector debugging connection management

[Joseph Pecoraro]

Created attachment 217351 [details]
[PATCH] Part 2 - Make JSContext and WebCore::Page remote debuggables

[Joseph Pecoraro]

Created attachment 217352 [details]
[PATCH] Part 3 - Remove old WebInspector/mac implementation

[Joseph Pecoraro]

This is the first set of patches. I put r- on each of them because, at least for the APIs included in them because they include FIXMEs and new APIs that I'll need to get reviewed separately.

But really, I don't want to go even further than this without some kind of high level review. I'm open to suggestion to redesign sections of this before it gets into the tree.

I've tested this on both iOS and OS X, and on OS X with apps that only link JavaScriptCore to make sure they would show up as debuggable targets. Actually opening up a remote inspector window will be the next step, followed by piecewise including features.

[Timothy Hatcher]

Comment on attachment 217350 [details]
[PATCH] Part 1 - JSC remote inspector debugging connection management

View in context: https://bugs.webkit.org/attachment.cgi?id=217350&action=review

> Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:87
> +    do {
> +        nextValidIdentifier = m_nextAvailableIdentifier++;
> +    } while (!nextValidIdentifier || nextValidIdentifier == std::numeric_limits<unsigned>::max() || m_debuggableMap.contains(nextValidIdentifier));

Should this reset m_nextAvailableIdentifier back to 1 when std::numeric_limits<unsigned>::max() is reached? Maybe use size_t to have more identifiers?

> Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:211
> +    m_xpcConnection->sendMessage(@"syn", nil);

Every time I see @"syn" I wonder about it. A comment that this can be any string would help I think.

> Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:279
> +        [debuggableDetails setObject:name forKey:WIRURLKey];
> +        [debuggableDetails setObject:name forKey:WIRTitleKey];

Can't you do: debuggableDetails[WIRURLKey] = url; now?

Ditto for any setObject:forKey:.

> Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:355
> +        [[NSNotificationCenter defaultCenter] postNotificationName:@"_WebViewRemoteInspectorHasSessionChangedNotification" object:nil];

Move @"_WebViewRemoteInspectorHasSessionChangedNotification" into a constant?

> Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:365
> +    NSNumber *pageId = [userInfo objectForKey:WIRPageIdentifierKey];
> +    if (!pageId)
> +        return;

pageId in JSC? This should be a different name even if the constant can't change. Still, the content name could change and the value stays the old for compat.

> Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h:34
> +#define WIRSimulatorTCPPortNumber               27753
> +#define WIRXPCMachPortName                      "com.apple.webinspector"

Would be nice to not use #define. const unsigned and const char* const!

> Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h:47
> +#define WIRPageIdentifierKey                    @"WIRPageIdentifierKey"

WIRContextIdentifierKey? WIRDebuggableIdentifierKey?

> Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggable.h:57
> +    virtual String name() const { return String(); } // JavaScript
> +    virtual String title() const { return String(); } // Web

I figured these would share name().

[Timothy Hatcher]

Comment on attachment 217351 [details]
[PATCH] Part 2 - Make JSContext and WebCore::Page remote debuggables

View in context: https://bugs.webkit.org/attachment.cgi?id=217351&action=review

> Source/JavaScriptCore/API/JSContext.mm:183
> +    return [(NSString *)JSStringCopyCFString(kCFAllocatorDefault, name) autorelease];

static_cast?

> Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:205
> +void WebInspectorClient::hideIndicate()

Odd wording here. hideIndication?

[Timothy Hatcher]

Comment on attachment 217352 [details]
[PATCH] Part 3 - Remove old WebInspector/mac implementation

Woot!

[Timothy Hatcher]

Looks good to me.

[Joseph Pecoraro]

(In reply to comment #5)
> (From update of attachment 217350 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217350&action=review
> 
> > Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:87
> > +    do {
> > +        nextValidIdentifier = m_nextAvailableIdentifier++;
> > +    } while (!nextValidIdentifier || nextValidIdentifier == std::numeric_limits<unsigned>::max() || m_debuggableMap.contains(nextValidIdentifier));
> 
> Should this reset m_nextAvailableIdentifier back to 1 when std::numeric_limits<unsigned>::max() is reached? Maybe use size_t to have more identifiers?

I don't really expect an app to have eventually opened UINT_MAX WebViews/JSContexts. Setting back to 1 when reaching max would just save a cycle and lookup (being unsigned it would overflow back to 0). I'd prefer this simple implementation.


> > Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:211
> > +    m_xpcConnection->sendMessage(@"syn", nil);
> 
> Every time I see @"syn" I wonder about it. A comment that this can be any string would help I think.

Good idea! Will do.


> > Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:279
> > +        [debuggableDetails setObject:name forKey:WIRURLKey];
> > +        [debuggableDetails setObject:name forKey:WIRTitleKey];
> 
> Can't you do: debuggableDetails[WIRURLKey] = url; now?
> 
> Ditto for any setObject:forKey:.

I probably could. I haven't seen anyone else using this syntax, but it would be nice here.


> > Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:355
> > +        [[NSNotificationCenter defaultCenter] postNotificationName:@"_WebViewRemoteInspectorHasSessionChangedNotification" object:nil];
> 
> Move @"_WebViewRemoteInspectorHasSessionChangedNotification" into a constant?

I'm actually going to leave this a FIXME and address it later. This can't fulfill it's legacy task as written (imagine if this was in a WebProcess, the notification is intended to be useful by the UIProcess).


> > Source/JavaScriptCore/inspector/remote/RemoteInspector.mm:365
> > +    NSNumber *pageId = [userInfo objectForKey:WIRPageIdentifierKey];
> > +    if (!pageId)
> > +        return;
> 
> pageId in JSC? This should be a different name even if the constant can't change. Still, the content name could change and the value stays the old for compat.

I agree, I planned to do some naming cleanup now that things are even more generic.


> > Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h:34
> > +#define WIRSimulatorTCPPortNumber               27753
> > +#define WIRXPCMachPortName                      "com.apple.webinspector"
> 
> Would be nice to not use #define. const unsigned and const char* const!

I'll see what I can do, I'll ask you about this off list.


> > Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h:47
> > +#define WIRPageIdentifierKey                    @"WIRPageIdentifierKey"
> 
> WIRContextIdentifierKey? WIRDebuggableIdentifierKey?

I like Debuggable!


> > Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggable.h:57
> > +    virtual String name() const { return String(); } // JavaScript
> > +    virtual String title() const { return String(); } // Web
> 
> I figured these would share name().

This is a great idea!

[Joseph Pecoraro]

(In reply to comment #6)
> (From update of attachment 217351 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=217351&action=review
> 
> > Source/JavaScriptCore/API/JSContext.mm:183
> > +    return [(NSString *)JSStringCopyCFString(kCFAllocatorDefault, name) autorelease];
> 
> static_cast?

Apparently this doesn't work for bridged types:

Source/JavaScriptCore/API/JSContext.mm:183:13: error: static_cast from 'CFStringRef' (aka 'const __CFString *') to 'NSString *' is not allowed


> > Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm:205
> > +void WebInspectorClient::hideIndicate()
> 
> Odd wording here. hideIndication?

Will do

[Joseph Pecoraro]

Created attachment 217593 [details]
[PATCH] Part 1 - JSC remote inspector debugging connection management

[Joseph Pecoraro]

Created attachment 217594 [details]
[PATCH] Part 2 - Make JSContext and WebCore::Page remote debuggables

[Joseph Pecoraro]

Created attachment 217595 [details]
[PATCH] Part 3 - Remove old WebInspector/mac implementation

[WebKit Commit Bot]

Attachment 217593 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/inspector/InspectorFrontendChannel.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspector.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspector.mm', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggable.cpp', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggable.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggableConnection.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggableConnection.mm', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorXPCConnection.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorXPCConnection.mm', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/ios/WebCoreThread.cpp', u'Source/WTF/wtf/ios/WebCoreThread.h']" exit_code: 1
Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggable.h:50:  The parameter name "allowed" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggableConnection.h:44:  The parameter name "type" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/ChangeLog:9:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:11:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:13:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/inspector/remote/RemoteInspector.h:69:  The parameter name "debuggableInfo" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/inspector/remote/RemoteInspectorXPCConnection.h:59:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/inspector/remote/RemoteInspectorXPCConnection.h:60:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 8 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 217593 [details]
[PATCH] Part 1 - JSC remote inspector debugging connection management

Attachment 217593 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/32578038

[Build Bot]

Comment on attachment 217593 [details]
[PATCH] Part 1 - JSC remote inspector debugging connection management

Attachment 217593 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/32518034

[Joseph Pecoraro]

Created attachment 217706 [details]
[PATCH] Part 1 - JSC remote inspector debugging connection management

Fix style issues. Maybe fixed the build issue... but I don't really know why LD doesn't find the symbol. It is there in -framework CoreFoundation in 10.8. This code was fine in WebKit, but not fine in JavaScriptCore?

[WebKit Commit Bot]

Attachment 217706 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/inspector/InspectorFrontendChannel.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspector.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspector.mm', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggable.cpp', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggable.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggableConnection.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggableConnection.mm', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorXPCConnection.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorXPCConnection.mm', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/ios/WebCoreThread.cpp', u'Source/WTF/wtf/ios/WebCoreThread.h']" exit_code: 1
Source/JavaScriptCore/ChangeLog:9:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:11:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:13:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 3 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 217706 [details]
[PATCH] Part 1 - JSC remote inspector debugging connection management

Attachment 217706 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/34508048

[Build Bot]

Comment on attachment 217706 [details]
[PATCH] Part 1 - JSC remote inspector debugging connection management

Attachment 217706 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/33858061

[Joseph Pecoraro]

Created attachment 217725 [details]
[PATCH] Part 1 - JSC remote inspector debugging connection management

Now with extern "C".

[WebKit Commit Bot]

Attachment 217725 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/inspector/InspectorFrontendChannel.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspector.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspector.mm', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggable.cpp', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggable.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggableConnection.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggableConnection.mm', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorXPCConnection.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorXPCConnection.mm', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/ios/WebCoreThread.cpp', u'Source/WTF/wtf/ios/WebCoreThread.h']" exit_code: 1
Source/JavaScriptCore/ChangeLog:9:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:11:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:13:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 3 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Timothy Hatcher]

Comment on attachment 217594 [details]
[PATCH] Part 2 - Make JSContext and WebCore::Page remote debuggables

View in context: https://bugs.webkit.org/attachment.cgi?id=217594&action=review

> Source/JavaScriptCore/API/JSContextRef.cpp:234
> +    }
> +    ExecState* exec = toJS(ctx);

I'd put a newline in-between these lines.

> Source/JavaScriptCore/API/JSContextRef.cpp:246
> +    }
> +    ExecState* exec = toJS(ctx);

Ditto.

> Source/JavaScriptCore/API/JSContextRef.cpp:258
> +    }
> +    ExecState* exec = toJS(ctx);

Ditto.

[Joseph Pecoraro]

Created attachment 218236 [details]
[PATCH] Combined For Bots

Going to try to catch any platform issues before landing, here is a combined rebased patch for the bots to chew on.

[WebKit Commit Bot]

Attachment 218236 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSContext.h', u'Source/JavaScriptCore/API/JSContext.mm', u'Source/JavaScriptCore/API/JSContextRef.cpp', u'Source/JavaScriptCore/API/JSContextRef.h', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/inspector/InspectorFrontendChannel.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspector.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspector.mm', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggable.cpp', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggable.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggableConnection.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggableConnection.mm', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorXPCConnection.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorXPCConnection.mm', u'Source/JavaScriptCore/runtime/JSGlobalObject.cpp', u'Source/JavaScriptCore/runtime/JSGlobalObject.h', u'Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.cpp', u'Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.h', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/ios/WebCoreThread.cpp', u'Source/WTF/wtf/ios/WebCoreThread.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/JSDOMGlobalObject.cpp', u'Source/WebCore/inspector/InspectorClient.h', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorController.h', u'Source/WebCore/inspector/InspectorFrontendChannel.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/page/ContextMenuController.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/page/PageDebuggable.cpp', u'Source/WebCore/page/PageDebuggable.h', u'Source/WebKit/ChangeLog', u'Source/WebKit/WebKit.xcodeproj/project.pbxproj', u'Source/WebKit/cf/ChangeLog', u'Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp', u'Source/WebKit/ios/ChangeLog', u'Source/WebKit/ios/WebCoreSupport/WebInspectorClientIOS.mm', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorClientRegistry.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorClientRegistry.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorRelayDefinitions.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorRemoteChannel.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorRemoteChannel.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServer.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServer.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnection.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnection.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnectionController.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnectionController.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorXPCWrapper.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorXPCWrapper.m', u'Source/WebKit/mac/WebKit.exp', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/mac/WebView/WebViewData.h', u'Source/WebKit/mac/WebView/WebViewData.mm', u'Source/WebKit/mac/WebView/WebViewInternal.h', u'Source/WebKit/mac/WebView/WebViewPrivate.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in']" exit_code: 1
ERROR: Source/WebCore/page/Page.h:184:  The parameter name "allowed" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/page/PageDebuggable.h:53:  The parameter name "indicating" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/inspector/InspectorFrontendChannel.h:27:  #ifndef header guard has wrong style, please use: InspectorFrontendChannel_h  [build/header_guard] [5]
ERROR: Source/JavaScriptCore/ChangeLog:49:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/JavaScriptCore/ChangeLog:51:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/JavaScriptCore/ChangeLog:53:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/inspector/InspectorController.h:113:  The parameter name "indicating" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/runtime/JSGlobalObject.h:430:  The parameter name "enabled" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/runtime/JSGlobalObject.h:433:  The parameter name "name" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 9 in 48 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Joseph Pecoraro]

GTK build fails:

In file included from ../../Source/WebCore/testing/Internals.cpp:62:0:
../../Source/WebCore/inspector/InspectorFrontendChannel.h:30:53: fatal error: JavaScriptCore/InspectorFrontendChannel.h: No such file or directory
 #include <JavaScriptCore/InspectorFrontendChannel.h>

Oops, I may have missed some project files.

I have a set of future patches which did this, and which also create forwarding headers for these and includes via <inspector/InspectorFrontendChannel.h>. I'll roll that into this and see if that gets things building on these ports.

[EFL EWS Bot]

Comment on attachment 218236 [details]
[PATCH] Combined For Bots

Attachment 218236 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/42298045

[Joseph Pecoraro]

Created attachment 218243 [details]
[PATCH] Combined For Bots 2

[WebKit Commit Bot]

Attachment 218243 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSContext.h', u'Source/JavaScriptCore/API/JSContext.mm', u'Source/JavaScriptCore/API/JSContextRef.cpp', u'Source/JavaScriptCore/API/JSContextRef.h', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.am', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/inspector/InspectorFrontendChannel.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspector.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspector.mm', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggable.cpp', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggable.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggableConnection.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggableConnection.mm', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorXPCConnection.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorXPCConnection.mm', u'Source/JavaScriptCore/runtime/JSGlobalObject.cpp', u'Source/JavaScriptCore/runtime/JSGlobalObject.h', u'Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.cpp', u'Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.h', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/ios/WebCoreThread.cpp', u'Source/WTF/wtf/ios/WebCoreThread.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/ForwardingHeaders/inspector/InspectorFrontendChannel.h', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/JSDOMGlobalObject.cpp', u'Source/WebCore/inspector/InspectorClient.h', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorController.h', u'Source/WebCore/inspector/InspectorFrontendChannel.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/page/ContextMenuController.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/page/PageDebuggable.cpp', u'Source/WebCore/page/PageDebuggable.h', u'Source/WebKit/ChangeLog', u'Source/WebKit/WebKit.xcodeproj/project.pbxproj', u'Source/WebKit/cf/ChangeLog', u'Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp', u'Source/WebKit/ios/ChangeLog', u'Source/WebKit/ios/WebCoreSupport/WebInspectorClientIOS.mm', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorClientRegistry.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorClientRegistry.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorRelayDefinitions.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorRemoteChannel.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorRemoteChannel.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServer.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServer.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnection.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnection.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnectionController.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnectionController.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorXPCWrapper.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorXPCWrapper.m', u'Source/WebKit/mac/WebKit.exp', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/mac/WebView/WebViewData.h', u'Source/WebKit/mac/WebView/WebViewData.mm', u'Source/WebKit/mac/WebView/WebViewInternal.h', u'Source/WebKit/mac/WebView/WebViewPrivate.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in']" exit_code: 1
ERROR: Source/WebCore/page/Page.h:184:  The parameter name "allowed" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ChangeLog:49:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/JavaScriptCore/ChangeLog:51:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/JavaScriptCore/ChangeLog:53:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/page/PageDebuggable.h:53:  The parameter name "indicating" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/inspector/InspectorFrontendChannel.h:27:  #ifndef header guard has wrong style, please use: InspectorFrontendChannel_h  [build/header_guard] [5]
ERROR: Source/WebCore/inspector/InspectorController.h:113:  The parameter name "indicating" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/runtime/JSGlobalObject.h:430:  The parameter name "enabled" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/runtime/JSGlobalObject.h:433:  The parameter name "name" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 9 in 54 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EFL EWS Bot]

Comment on attachment 218243 [details]
[PATCH] Combined For Bots 2

Attachment 218243 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/42258046

[Joseph Pecoraro]

Created attachment 218248 [details]
[PATCH] Combined For Bots 3

Updating CMakeLists.

[WebKit Commit Bot]

Attachment 218248 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSContext.h', u'Source/JavaScriptCore/API/JSContext.mm', u'Source/JavaScriptCore/API/JSContextRef.cpp', u'Source/JavaScriptCore/API/JSContextRef.h', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.am', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/inspector/InspectorFrontendChannel.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspector.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspector.mm', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggable.cpp', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggable.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggableConnection.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggableConnection.mm', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorXPCConnection.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorXPCConnection.mm', u'Source/JavaScriptCore/runtime/JSGlobalObject.cpp', u'Source/JavaScriptCore/runtime/JSGlobalObject.h', u'Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.cpp', u'Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.h', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/ios/WebCoreThread.cpp', u'Source/WTF/wtf/ios/WebCoreThread.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/ForwardingHeaders/inspector/InspectorFrontendChannel.h', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/JSDOMGlobalObject.cpp', u'Source/WebCore/inspector/InspectorClient.h', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorController.h', u'Source/WebCore/inspector/InspectorFrontendChannel.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/page/ContextMenuController.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/page/PageDebuggable.cpp', u'Source/WebCore/page/PageDebuggable.h', u'Source/WebKit/ChangeLog', u'Source/WebKit/WebKit.xcodeproj/project.pbxproj', u'Source/WebKit/cf/ChangeLog', u'Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp', u'Source/WebKit/ios/ChangeLog', u'Source/WebKit/ios/WebCoreSupport/WebInspectorClientIOS.mm', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorClientRegistry.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorClientRegistry.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorRelayDefinitions.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorRemoteChannel.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorRemoteChannel.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServer.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServer.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnection.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnection.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnectionController.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnectionController.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorXPCWrapper.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorXPCWrapper.m', u'Source/WebKit/mac/WebKit.exp', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/mac/WebView/WebViewData.h', u'Source/WebKit/mac/WebView/WebViewData.mm', u'Source/WebKit/mac/WebView/WebViewInternal.h', u'Source/WebKit/mac/WebView/WebViewPrivate.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in']" exit_code: 1
ERROR: Source/WebCore/page/Page.h:184:  The parameter name "allowed" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/page/PageDebuggable.h:53:  The parameter name "indicating" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ChangeLog:49:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/JavaScriptCore/ChangeLog:51:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/JavaScriptCore/ChangeLog:53:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/inspector/InspectorFrontendChannel.h:27:  #ifndef header guard has wrong style, please use: InspectorFrontendChannel_h  [build/header_guard] [5]
ERROR: Source/WebCore/inspector/InspectorController.h:113:  The parameter name "indicating" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/runtime/JSGlobalObject.h:430:  The parameter name "enabled" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/runtime/JSGlobalObject.h:433:  The parameter name "name" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 9 in 55 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Joseph Pecoraro]

Created attachment 218250 [details]
[PATCH] Combined For Bots (Test Different File Names)

[WebKit Commit Bot]

Attachment 218250 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSContext.h', u'Source/JavaScriptCore/API/JSContext.mm', u'Source/JavaScriptCore/API/JSContextRef.cpp', u'Source/JavaScriptCore/API/JSContextRef.h', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.am', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/inspector/FrontendChannel.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspector.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspector.mm', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggable.cpp', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggable.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggableConnection.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggableConnection.mm', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorXPCConnection.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorXPCConnection.mm', u'Source/JavaScriptCore/runtime/JSGlobalObject.cpp', u'Source/JavaScriptCore/runtime/JSGlobalObject.h', u'Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.cpp', u'Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.h', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/ios/WebCoreThread.cpp', u'Source/WTF/wtf/ios/WebCoreThread.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/ForwardingHeaders/inspector/FrontendChannel.h', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/JSDOMGlobalObject.cpp', u'Source/WebCore/inspector/InspectorClient.h', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorController.h', u'Source/WebCore/inspector/InspectorFrontendChannel.h', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/page/ContextMenuController.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/page/PageDebuggable.cpp', u'Source/WebCore/page/PageDebuggable.h', u'Source/WebKit/ChangeLog', u'Source/WebKit/WebKit.xcodeproj/project.pbxproj', u'Source/WebKit/cf/ChangeLog', u'Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp', u'Source/WebKit/ios/ChangeLog', u'Source/WebKit/ios/WebCoreSupport/WebInspectorClientIOS.mm', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorClientRegistry.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorClientRegistry.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorRelayDefinitions.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorRemoteChannel.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorRemoteChannel.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServer.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServer.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnection.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnection.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnectionController.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnectionController.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorXPCWrapper.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorXPCWrapper.m', u'Source/WebKit/mac/WebKit.exp', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/mac/WebView/WebViewData.h', u'Source/WebKit/mac/WebView/WebViewData.mm', u'Source/WebKit/mac/WebView/WebViewInternal.h', u'Source/WebKit/mac/WebView/WebViewPrivate.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in']" exit_code: 1
ERROR: Source/WebCore/page/Page.h:184:  The parameter name "allowed" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/page/PageDebuggable.h:53:  The parameter name "indicating" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/ChangeLog:49:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/JavaScriptCore/ChangeLog:51:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/JavaScriptCore/ChangeLog:53:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/WebCore/inspector/InspectorFrontendChannel.h:27:  #ifndef header guard has wrong style, please use: InspectorFrontendChannel_h  [build/header_guard] [5]
ERROR: Source/WebCore/inspector/InspectorController.h:113:  The parameter name "indicating" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/runtime/JSGlobalObject.h:430:  The parameter name "enabled" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/runtime/JSGlobalObject.h:433:  The parameter name "name" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 9 in 55 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EFL EWS Bot]

Comment on attachment 218248 [details]
[PATCH] Combined For Bots 3

Attachment 218248 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/41588019

[kov's GTK+ EWS bot]

Comment on attachment 218248 [details]
[PATCH] Combined For Bots 3

Attachment 218248 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/42418010

[Joseph Pecoraro]

Looks like I can't have two files with the same name even if they have different include paths. I'll look into cleaning that up then.

[Joseph Pecoraro]

Created attachment 218305 [details]
[PATCH] Combined For Bots 5

Rename's WebCore/inspector/InspectorFrontendChannel.h to InspectorForwarding.h.

[Joseph Pecoraro]

Created attachment 218315 [details]
[PATCH] Combined For Bots 6

Rebaselined.

[WebKit Commit Bot]

Attachment 218315 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSContext.h', u'Source/JavaScriptCore/API/JSContext.mm', u'Source/JavaScriptCore/API/JSContextRef.cpp', u'Source/JavaScriptCore/API/JSContextRef.h', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.am', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/inspector/InspectorFrontendChannel.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspector.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspector.mm', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggable.cpp', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggable.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggableConnection.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggableConnection.mm', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorXPCConnection.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorXPCConnection.mm', u'Source/JavaScriptCore/runtime/JSGlobalObject.cpp', u'Source/JavaScriptCore/runtime/JSGlobalObject.h', u'Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.cpp', u'Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.h', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/ios/WebCoreThread.cpp', u'Source/WTF/wtf/ios/WebCoreThread.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/ForwardingHeaders/inspector/InspectorFrontendChannel.h', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/JSDOMGlobalObject.cpp', u'Source/WebCore/inspector/CodeGeneratorInspectorStrings.py', u'Source/WebCore/inspector/InspectorBackendDispatcher.cpp', u'Source/WebCore/inspector/InspectorClient.h', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorController.h', u'Source/WebCore/inspector/InspectorForwarding.h', u'Source/WebCore/inspector/InspectorFrontendChannel.h', u'Source/WebCore/inspector/InspectorWorkerAgent.cpp', u'Source/WebCore/inspector/WorkerInspectorController.cpp', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/page/ContextMenuController.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/page/PageDebuggable.cpp', u'Source/WebCore/page/PageDebuggable.h', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/ChangeLog', u'Source/WebKit/WebKit.xcodeproj/project.pbxproj', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.h', u'Source/WebKit/cf/ChangeLog', u'Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h', u'Source/WebKit/ios/ChangeLog', u'Source/WebKit/ios/WebCoreSupport/WebInspectorClientIOS.mm', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorClientRegistry.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorClientRegistry.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorRelayDefinitions.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorRemoteChannel.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorRemoteChannel.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServer.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServer.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnection.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnection.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnectionController.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnectionController.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorXPCWrapper.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorXPCWrapper.m', u'Source/WebKit/mac/WebKit.exp', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/mac/WebView/WebViewData.h', u'Source/WebKit/mac/WebView/WebViewData.mm', u'Source/WebKit/mac/WebView/WebViewInternal.h', u'Source/WebKit/mac/WebView/WebViewPrivate.h', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebCoreSupport/WebInspectorClient.h', u'Source/WebKit/wince/ChangeLog', u'Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in']" exit_code: 1
ERROR: Source/JavaScriptCore/ChangeLog:11:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/JavaScriptCore/ChangeLog:13:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/JavaScriptCore/ChangeLog:15:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 3 in 72 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Joseph Pecoraro]

Created attachment 218324 [details]
[PATCH] Combined For Bots 7

Now with WebKit2 include updates.

[Joseph Pecoraro]

Created attachment 218329 [details]
[PATCH] Combined For Bots 8

[WebKit Commit Bot]

Attachment 218329 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSContext.h', u'Source/JavaScriptCore/API/JSContext.mm', u'Source/JavaScriptCore/API/JSContextRef.cpp', u'Source/JavaScriptCore/API/JSContextRef.h', u'Source/JavaScriptCore/CMakeLists.txt', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/GNUmakefile.am', u'Source/JavaScriptCore/GNUmakefile.list.am', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj', u'Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters', u'Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj', u'Source/JavaScriptCore/inspector/InspectorFrontendChannel.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspector.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspector.mm', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorConstants.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggable.cpp', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggable.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggableConnection.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggableConnection.mm', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorXPCConnection.h', u'Source/JavaScriptCore/inspector/remote/RemoteInspectorXPCConnection.mm', u'Source/JavaScriptCore/runtime/JSGlobalObject.cpp', u'Source/JavaScriptCore/runtime/JSGlobalObject.h', u'Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.cpp', u'Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.h', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/ios/WebCoreThread.cpp', u'Source/WTF/wtf/ios/WebCoreThread.h', u'Source/WebCore/ChangeLog', u'Source/WebCore/ForwardingHeaders/inspector/InspectorFrontendChannel.h', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/bindings/js/JSDOMGlobalObject.cpp', u'Source/WebCore/inspector/CodeGeneratorInspectorStrings.py', u'Source/WebCore/inspector/InspectorBackendDispatcher.cpp', u'Source/WebCore/inspector/InspectorClient.h', u'Source/WebCore/inspector/InspectorController.cpp', u'Source/WebCore/inspector/InspectorController.h', u'Source/WebCore/inspector/InspectorForwarding.h', u'Source/WebCore/inspector/InspectorFrontendChannel.h', u'Source/WebCore/inspector/InspectorWorkerAgent.cpp', u'Source/WebCore/inspector/WorkerInspectorController.cpp', u'Source/WebCore/loader/FrameLoader.cpp', u'Source/WebCore/page/ContextMenuController.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/Page.h', u'Source/WebCore/page/PageDebuggable.cpp', u'Source/WebCore/page/PageDebuggable.h', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/ChangeLog', u'Source/WebKit/WebKit.xcodeproj/project.pbxproj', u'Source/WebKit/blackberry/ChangeLog', u'Source/WebKit/blackberry/WebCoreSupport/InspectorClientBlackBerry.h', u'Source/WebKit/cf/ChangeLog', u'Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp', u'Source/WebKit/efl/ChangeLog', u'Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h', u'Source/WebKit/gtk/ChangeLog', u'Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h', u'Source/WebKit/ios/ChangeLog', u'Source/WebKit/ios/WebCoreSupport/WebInspectorClientIOS.mm', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h', u'Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorClientRegistry.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorClientRegistry.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorRelayDefinitions.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorRemoteChannel.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorRemoteChannel.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServer.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServer.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnection.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnection.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnectionController.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorServerWebViewConnectionController.mm', u'Source/WebKit/mac/WebInspector/remote/WebInspectorXPCWrapper.h', u'Source/WebKit/mac/WebInspector/remote/WebInspectorXPCWrapper.m', u'Source/WebKit/mac/WebKit.exp', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/mac/WebView/WebViewData.h', u'Source/WebKit/mac/WebView/WebViewData.mm', u'Source/WebKit/mac/WebView/WebViewInternal.h', u'Source/WebKit/mac/WebView/WebViewPrivate.h', u'Source/WebKit/win/ChangeLog', u'Source/WebKit/win/WebCoreSupport/WebInspectorClient.h', u'Source/WebKit/wince/ChangeLog', u'Source/WebKit/wince/WebCoreSupport/InspectorClientWinCE.h', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorClient.h', u'Source/WebKit2/WebProcess/WebPage/WebInspector.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/com.apple.WebProcess.sb.in']" exit_code: 1
ERROR: Source/JavaScriptCore/ChangeLog:11:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/JavaScriptCore/ChangeLog:13:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
ERROR: Source/JavaScriptCore/ChangeLog:15:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 3 in 74 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EFL EWS Bot]

Comment on attachment 218329 [details]
[PATCH] Combined For Bots 8

Attachment 218329 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/43208018

[Joseph Pecoraro]

(In reply to comment #44)
> (From update of attachment 218329 [details])
> Attachment 218329 [details] did not pass efl-wk2-ews (efl-wk2):
> Output: http://webkit-queues.appspot.com/results/43208018

This actually doesn't look related to this patch. I'm going to forge ahead and land this.

[Joseph Pecoraro]

Landed <http://trac.webkit.org/changeset/160099>.

[Joseph Pecoraro]

Attempted Windows Build Fix: <http://trac.webkit.org/changeset/160102>

[Joseph Pecoraro]

Attempted Windows Build Fix 2: <http://trac.webkit.org/changeset/160103>