Bug 124595

Summary: Get rid of bare new in SVGAnimatedColorAnimator::constructFromString()
Product: WebKit Reporter: Sergio Correia (qrwteyrutiyoup) <sergio>
Component: New BugsAssignee: Sergio Correia (qrwteyrutiyoup) <sergio>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, d-r, fmalita, gyuyoung.kim, pdr, schenney, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sergio Correia (qrwteyrutiyoup)
Reported 2013-11-19 12:18:38 PST
Get rid of bare new in SVGAnimatedColorAnimator::constructFromString()
Attachments
Patch (30.67 KB, patch)
2013-11-19 12:20 PST, Sergio Correia (qrwteyrutiyoup) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sergio Correia (qrwteyrutiyoup)
Comment 1 2013-11-19 12:19:23 PST
Use std::unique_ptr instead, to manage the arguments passed to the create methods of SVGAnimatedType.
Sergio Correia (qrwteyrutiyoup)
Comment 2 2013-11-19 12:20:25 PST
Created attachment 217315 [details] Patch
Darin Adler
Comment 3 2013-11-19 12:46:32 PST
Comment on attachment 217315 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217315&action=review > Source/WebCore/svg/SVGAnimatedTypeAnimator.h:79 > + executeAction<AnimValType>(StartAnimationAction, animatedTypes, 0, copy.get()); Given this call site, looks like executeAction should be taking a reference rather than a pointer. Some day we should make that change.
WebKit Commit Bot
Comment 4 2013-11-19 13:12:08 PST
Comment on attachment 217315 [details] Patch Clearing flags on attachment: 217315 Committed r159516: <http://trac.webkit.org/changeset/159516>
WebKit Commit Bot
Comment 5 2013-11-19 13:12:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.