Bug 124560 – [EFL] Initialize efreet before getting directories

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Ryuan Choi]

WebKit/Efl use efreet to get several directories including home dierectory since r123731.

But it does not call efreet_init/efreet_shutdown explicitly.

If it is not called, we will get below error(I reproduced it on EFL 1.8)

ERROR: Failed to create database file '/WebKitEfl/LocalStorage/StorageTracker.db'
/workspace/project/webkit/efl-webkit/Source/WebCore/storage/StorageTracker.cpp(144) : void WebCore::StorageTracker::openTrackerDatabase(bool)

[Ryuan Choi]

Created attachment 217270 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 217270 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217270&action=review

Looks good except for a log.

> Source/WebKit2/UIProcess/API/efl/ewk_main.cpp:83
> +        CRITICAL("could not init ecore_imf.");

ecore imf ? Isn't it correct "init efreet ?

[Ryuan Choi]

Comment on attachment 217270 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217270&action=review

>> Source/WebKit2/UIProcess/API/efl/ewk_main.cpp:83
>> +        CRITICAL("could not init ecore_imf.");
> 
> ecore imf ? Isn't it correct "init efreet ?

Oops, c&p mistake. I will fix it.

Thanks.

[Ryuan Choi]

Committed r159486: <http://trac.webkit.org/changeset/159486>

[Ryuan Choi]

Comment on attachment 217270 [details]
Patch

Clearing flags.