Summary: | WebPageGroup's should keep track of what processes they are being used by | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||
Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achicu, buildbot, commit-queue, dino, rniwa, zan | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 124859 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Sam Weinig
2013-11-18 20:18:57 PST
Created attachment 217266 [details]
Patch
Comment on attachment 217266 [details] Patch Attachment 217266 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/28688033 New failing tests: http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html Created attachment 217272 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 217266 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217266&action=review > Source/WebKit2/ChangeLog:36 > + Get the already create page group on creation. Already created? Committed r159603: <http://trac.webkit.org/changeset/159603> Maybe the crash we're seeing here is caused by this patch? http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK2%20(Tests)/r159603%20(889)/results.html Rolled out in https://trac.webkit.org/r159631. There is typo in WebProcessProxy::disconnect() where I meant pageGroups.size() not frames.size() :(. Somehow, this also appears to have broken a single XHR test: <http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fxmlhttprequest%2Faccess-control-repeated-failed-preflight-crash.html>. Which EWS has told you about before landing! Committed r159740: <http://trac.webkit.org/changeset/159740> (In reply to comment #8) > Somehow, this also appears to have broken a single XHR test: <http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fxmlhttprequest%2Faccess-control-repeated-failed-preflight-crash.html>. Failing again on WK2 ports. (In reply to comment #11) > (In reply to comment #8) > > Somehow, this also appears to have broken a single XHR test: <http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fxmlhttprequest%2Faccess-control-repeated-failed-preflight-crash.html>. > > Failing again on WK2 ports. Yes, it's crashing the test. Re-opened since this is blocked by bug 124859 (In reply to comment #13) > Re-opened since this is blocked by bug 124859 The patch was also crashing the WebInspector. I had a fix, but by the time I've uploaded a fix, this patch got rolled out: https://bugs.webkit.org/show_bug.cgi?id=124864 Created attachment 218196 [details]
Patch
Committed r159982: <http://trac.webkit.org/changeset/159982> |