Bug 124556 – WebPageGroup's should keep track of what processes they are being used by

• Component: New Bugs
• Status: RESOLVED FIXED

[Sam Weinig]

WebPageGroup's should keep track of what processes they are being used by

[Sam Weinig]

Created attachment 217266 [details]
Patch

[Build Bot]

Comment on attachment 217266 [details]
Patch

Attachment 217266 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/28688033

New failing tests:
http/tests/xmlhttprequest/access-control-repeated-failed-preflight-crash.html

[Build Bot]

Created attachment 217272 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

Comment on attachment 217266 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=217266&action=review

> Source/WebKit2/ChangeLog:36
> +        Get the already create page group on creation.

Already created?

[Sam Weinig]

Committed r159603: <http://trac.webkit.org/changeset/159603>

[Ryosuke Niwa]

Maybe the crash we're seeing here is caused by this patch?

http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK2%20(Tests)/r159603%20(889)/results.html

[Sam Weinig]

Rolled out in https://trac.webkit.org/r159631.  There is typo in WebProcessProxy::disconnect() where I meant pageGroups.size() not frames.size() :(.

[Alexey Proskuryakov]

Somehow, this also appears to have broken a single XHR test: <http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fxmlhttprequest%2Faccess-control-repeated-failed-preflight-crash.html>.

[Alexey Proskuryakov]

Which EWS has told you about before landing!

[Sam Weinig]

Committed r159740: <http://trac.webkit.org/changeset/159740>

[Zan Dobersek]

(In reply to comment #8)
> Somehow, this also appears to have broken a single XHR test: <http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fxmlhttprequest%2Faccess-control-repeated-failed-preflight-crash.html>.

Failing again on WK2 ports.

[Dean Jackson]

(In reply to comment #11)
> (In reply to comment #8)
> > Somehow, this also appears to have broken a single XHR test: <http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fxmlhttprequest%2Faccess-control-repeated-failed-preflight-crash.html>.
> 
> Failing again on WK2 ports.

Yes, it's crashing the test.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 124859

[Alexandru Chiculita]

(In reply to comment #13)
> Re-opened since this is blocked by bug 124859

The patch was also crashing the WebInspector. I had a fix, but by the time I've uploaded a fix, this patch got rolled out:

https://bugs.webkit.org/show_bug.cgi?id=124864

[Sam Weinig]

Created attachment 218196 [details]
Patch

[Sam Weinig]

Committed r159982: <http://trac.webkit.org/changeset/159982>