Summary: | [ASAN] Building with trunk clang corrupts sandbox profile with comment from Compiler.h | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Farler <dfarler> | ||||
Component: | Web Template Framework | Assignee: | David Farler <dfarler> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, ap, benjamin, cmarcelo, commit-queue, ddkilzer, lisacarlon25, marshalblake, parkermark330, sam | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Mac | ||||||
OS: | All | ||||||
Attachments: |
|
Description
David Farler
2013-11-18 12:30:21 PST
Compiler.h should obviously use c-style comments. I'm a bit confused though. Is it even intentional that the #error is commented out? It got commented out without any explanation in <http://trac.webkit.org/changeset/157044>. (In reply to comment #1) > Compiler.h should obviously use c-style comments. This isn't obvious to me – what would that do in this case? ";;" are used to denote comments in sandbox profiles; would using C-style comments prevent this from getting printed to the profile or something? .sb.in files are processed with a C preprocessor, which removes /**/ comments. There are lots more in Compiler.h, so this C++ one is a mistake. (In reply to comment #1) > Compiler.h should obviously use c-style comments. > > I'm a bit confused though. Is it even intentional that the #error is commented out? It got commented out without any explanation in <http://trac.webkit.org/changeset/157044>. It was unintentional. I was using a trunk build of clang and probably ran into the same error as David’s seeing now. Since we only build on Xcode 5 now we can probably remove the quirk altogether. Created attachment 220539 [details]
Patch
Comment on attachment 220539 [details]
Patch
r=me
Comment on attachment 220539 [details] Patch Clearing flags on attachment: 220539 Committed r161451: <http://trac.webkit.org/changeset/161451> All reviewed patches have been landed. Closing bug. |