Bug 124450 – [Win] Re-enable JIT on 64-bit.

• Component: JavaScriptCore
• Status: RESOLVED DUPLICATE

Now that bug 124409 is fixed, I suggest we re-enable JIT on 64-bit.

Created attachment 217119 [details]
Patch

[Geoffrey Garen]

What kind of testing did you do for this patch?

(In reply to comment #2)
> What kind of testing did you do for this patch?

I only tested "normal" browsing on some common sites, which seemed to work fine.
Which test(s) should I run?

[Brent Fulgham]

I assume the run-javascriptcore-tests pass with this change?

[Geoffrey Garen]

> I only tested "normal" browsing on some common sites, which seemed to work fine.
> Which test(s) should I run?

run-javascriptcore-tests and run-webkit-tests.

Output from run-javascriptcore-tests (no crashes):

** The following Mozilla test failures have been introduced:
        ecma/Date/15.9.5.10-1.js
        ecma/Date/15.9.5.10-10.js
        ecma/Date/15.9.5.10-11.js
        ecma/Date/15.9.5.10-12.js
        ecma/Date/15.9.5.10-13.js
        ecma/Date/15.9.5.10-2.js
        ecma/Date/15.9.5.10-3.js
        ecma/Date/15.9.5.10-4.js
        ecma/Date/15.9.5.10-5.js
        ecma/Date/15.9.5.10-6.js
        ecma/Date/15.9.5.10-7.js
        ecma/Date/15.9.5.10-8.js
        ecma/Date/15.9.5.10-9.js
        ecma/Date/15.9.5.12-1.js
        ecma/Date/15.9.5.12-2.js
        ecma/Date/15.9.5.12-3.js
        ecma/Date/15.9.5.12-4.js
        ecma/Date/15.9.5.12-5.js
        ecma/Date/15.9.5.12-6.js
        ecma/Date/15.9.5.12-7.js
        ecma/Date/15.9.5.28-1.js
        ecma/Date/15.9.5.29-1.js
        ecma/Date/15.9.5.35-1.js
        ecma/Date/15.9.5.8.js
        ecma/String/15.5.4.6-2.js

Results for Mozilla tests:
    25 regressions found.
    0 tests fixed.

Created attachment 217219 [details]
JavaScript test results

Attached test results.

[Geoffrey Garen]

Comment on attachment 217119 [details]
Patch

Test results don't look good.

Now that bug 124946 is fixed, there are no errors:

Results for Mozilla tests:
    0 regressions found.
    0 tests fixed.
    OK.

[Brent Fulgham]

Comment on attachment 217119 [details]
Patch

I don't think that 64-bit Windows will build without this enabled.

[Brent Fulgham]

(In reply to comment #10)
> (From update of attachment 217119 [details])
> I don't think that 64-bit Windows will build without this enabled.

It won't.  See https://bugs.webkit.org/show_bug.cgi?id=125186

[Brent Fulgham]

This patch is pretty old now. Is it still usable? If not, could we rebaseline it so I can try to get it moving through review?

[Radar WebKit Bug Importer]

<rdar://problem/16487274>

(In reply to comment #12)
> This patch is pretty old now. Is it still usable? If not, could we rebaseline it so I can try to get it moving through review?

This is now a duplicate of bug 130638, since that one also enables JIT as well as LLINT.

*** This bug has been marked as a duplicate of bug 130638 ***

[Brent Fulgham]

Comment on attachment 217119 [details]
Patch

Clearing flags so this duplicate doesn't show up in the Request queue anymore.