Bug 124445

Summary: No way for policy client to determine if a the response’s MIME type can be shown
Product: WebKit Reporter: mitz
Component: WebKit2Assignee: mitz
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eflews.bot, gyuyoung.kim
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Add -[WKBrowsingContextController canShowMIMEType:]
none
Add canShowMIMEType to DecidePolicyForResponseSync and expose it via the UI process API sam: review+, eflews.bot: commit-queue-

mitz
Reported 2013-11-15 17:02:53 PST
[Cocoa] Add -[WKBrowsingContextController canShowMIMEType:]
Attachments
Add -[WKBrowsingContextController canShowMIMEType:] (1.84 KB, patch)
2013-11-15 17:04 PST, mitz 		no flags
DetailsFormatted DiffDiff
Add canShowMIMEType to DecidePolicyForResponseSync and expose it via the UI process API (27.03 KB, patch)
2013-11-16 12:54 PST, mitz 		sam: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2013-11-15 17:04:25 PST
Created attachment 217105 [details] Add -[WKBrowsingContextController canShowMIMEType:]
mitz
Comment 2 2013-11-15 17:09:43 PST
Comment on attachment 217105 [details] Add -[WKBrowsingContextController canShowMIMEType:] Going to do something different to address the need for this.
mitz
Comment 3 2013-11-16 12:54:05 PST
Created attachment 217132 [details] Add canShowMIMEType to DecidePolicyForResponseSync and expose it via the UI process API
WebKit Commit Bot
Comment 4 2013-11-16 12:56:30 PST
Attachment 217132 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/CoreIPC/HandleMessage.h', u'Source/WebKit2/UIProcess/API/C/WKPage.h', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextController.mm', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h', u'Source/WebKit2/UIProcess/WebInspectorProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/UIProcess/WebPageProxy.messages.in', u'Source/WebKit2/UIProcess/WebPolicyClient.cpp', u'Source/WebKit2/UIProcess/WebPolicyClient.h', u'Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp', u'Tools/ChangeLog', u'Tools/MiniBrowser/mac/WK2BrowserWindowController.m', u'Tools/TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp', u'Tools/WebKitTestRunner/TestController.cpp', u'Tools/WebKitTestRunner/TestController.h']" exit_code: 1 Source/WebKit2/UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h:39: One space before end of line comments [whitespace/comments] [5] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
EFL EWS Bot
Comment 5 2013-11-16 13:05:17 PST
Comment on attachment 217132 [details] Add canShowMIMEType to DecidePolicyForResponseSync and expose it via the UI process API Attachment 217132 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/25278002
mitz
Comment 6 2013-11-17 12:28:35 PST
Fixed in <http://trac.webkit.org/r159387>.
Note You need to log in before you can comment on or make changes to this bug.