Bug 124392

Summary: Introduce FILTER_EFFECT_TYPE_CASTS, and use it
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED LATER    
Severity: Normal CC: commit-queue, dino, d-r, eflews.bot, fmalita, gyuyoung.kim, kling, kondapallykalyan, pdr, schenney
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Gyuyoung Kim
Reported 2013-11-14 21:20:01 PST
As a step to use toFoo(), I'd like to introduce FILTER_EFFECT_TYPE_CASTS. This macro lets child filter effect class generate toFEFoo(). This patch also adds isFEFoo() functions so that we check if casting class is correct child class.
Attachments
Patch (31.32 KB, patch)
2013-11-14 21:28 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Patch (31.31 KB, patch)
2013-11-14 21:42 PST, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2013-11-14 21:28:02 PST
Created attachment 217013 [details] Patch
EFL EWS Bot
Comment 2 2013-11-14 21:33:57 PST
Comment on attachment 217013 [details] Patch Attachment 217013 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/23708008
EFL EWS Bot
Comment 3 2013-11-14 21:36:11 PST
Comment on attachment 217013 [details] Patch Attachment 217013 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/23778006
Gyuyoung Kim
Comment 4 2013-11-14 21:42:20 PST
Created attachment 217014 [details] Patch
Gyuyoung Kim
Comment 5 2013-11-17 19:15:07 PST
isFEFoo() is too unneeded only to support type casts. So, I will file a bug again when I find more proper method to check child class type.
Note You need to log in before you can comment on or make changes to this bug.