| Summary: | [EFL] Layout tests with international text properties need to be rebaselined. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sun-woo Nam <sunny.nam> | ||||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Sun-woo Nam
2013-11-14 17:51:35 PST
Created attachment 217001 [details]
Patch
Comment on attachment 217001 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217001&action=review > LayoutTests/ChangeLog:6 > + Unreviewed, EFL gardening. This patch is close to *rebaseline*. So, please use *rebaseline* instead of *gardening*. > LayoutTests/ChangeLog:14 > + * platform/efl/fast/text/international/003-expected.txt: Renamed from LayoutTests/platform/efl-wk2/fast/text/international/003-expected.txt. Why do you need to move this from efl-wk1 to efl common place ? Created attachment 217006 [details]
Patch
(In reply to comment #0) > platform/efl-wk1/fast/text/international/003-expected.txt: Removed. > platform/efl-wk1/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed. > platform/efl-wk2/TestExpectations: > platform/efl/fast/text/international/002-expected.txt: > platform/efl/fast/text/international/003-expected.txt: Renamed from LayoutTests/platform/efl-wk2/fast/text/international/003-expected.txt. > platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt: Renamed from LayoutTests/platform/efl-wk2/fast/text/international/bidi-layout-across-linebreak-expected.txt. > > EFL international text rebaselined after r147668. Move some expectation files to efl common place because those files in wk1 are in exact accordance with files in wk2, and then delete the files in wk1 and wk2. Comment on attachment 217006 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217006&action=review > LayoutTests/ChangeLog:9 > + Move some expectation files to efl common place because those files in wk1 are in exact accordance with files in wk2, and then delete the files in wk1 and wk2. Looks fine. But, please do line break. This line is too long horizontally. > LayoutTests/ChangeLog:15 > + * platform/efl/fast/text/international/003-expected.txt: Renamed from LayoutTests/platform/efl-wk2/fast/text/international/003-expected.txt. ditto. > LayoutTests/ChangeLog:16 > + * platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt: Renamed from LayoutTests/platform/efl-wk2/fast/text/international/bidi-layout-across-linebreak-expected.txt. ditto. Created attachment 217015 [details]
Patch
Comment on attachment 217015 [details] Patch Clearing flags on attachment: 217015 Committed r159329: <http://trac.webkit.org/changeset/159329> All reviewed patches have been landed. Closing bug. |