Bug 124389

Summary:

[EFL] Layout tests with international text properties need to be rebaselined.

Product:

WebKit

Reporter:

Sun-woo Nam <sunny.nam>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Sun-woo Nam

Reported 2013-11-14 17:51:35 PST

platform/efl-wk1/fast/text/international/003-expected.txt: Removed. platform/efl-wk1/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed. platform/efl-wk2/TestExpectations: platform/efl/fast/text/international/002-expected.txt: platform/efl/fast/text/international/003-expected.txt: Renamed from LayoutTests/platform/efl-wk2/fast/text/international/003-expected.txt. platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt: Renamed from LayoutTests/platform/efl-wk2/fast/text/international/bidi-layout-across-linebreak-expected.txt. EFL international text rebaselined after r147668.

Attachments
Patch (67.48 KB, patch) 2013-11-14 17:53 PST, Sun-woo Nam	no flags	Details Formatted Diff Diff
Patch (67.65 KB, patch) 2013-11-14 19:11 PST, Sun-woo Nam	no flags	Details Formatted Diff Diff
Patch (67.67 KB, patch) 2013-11-14 22:38 PST, Sun-woo Nam	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Sun-woo Nam

Comment 1 2013-11-14 17:53:13 PST

Created attachment 217001 [details] Patch

Gyuyoung Kim

Comment 2 2013-11-14 18:27:54 PST

Comment on attachment 217001 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217001&action=review > LayoutTests/ChangeLog:6 > + Unreviewed, EFL gardening. This patch is close to *rebaseline*. So, please use *rebaseline* instead of *gardening*. > LayoutTests/ChangeLog:14 > + * platform/efl/fast/text/international/003-expected.txt: Renamed from LayoutTests/platform/efl-wk2/fast/text/international/003-expected.txt. Why do you need to move this from efl-wk1 to efl common place ?

Sun-woo Nam

Comment 3 2013-11-14 19:11:05 PST

Created attachment 217006 [details] Patch

Sun-woo Nam

Comment 4 2013-11-14 19:14:34 PST

(In reply to comment #0) > platform/efl-wk1/fast/text/international/003-expected.txt: Removed. > platform/efl-wk1/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed. > platform/efl-wk2/TestExpectations: > platform/efl/fast/text/international/002-expected.txt: > platform/efl/fast/text/international/003-expected.txt: Renamed from LayoutTests/platform/efl-wk2/fast/text/international/003-expected.txt. > platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt: Renamed from LayoutTests/platform/efl-wk2/fast/text/international/bidi-layout-across-linebreak-expected.txt. > > EFL international text rebaselined after r147668. Move some expectation files to efl common place because those files in wk1 are in exact accordance with files in wk2, and then delete the files in wk1 and wk2.

Gyuyoung Kim

Comment 5 2013-11-14 22:22:43 PST

Comment on attachment 217006 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=217006&action=review > LayoutTests/ChangeLog:9 > + Move some expectation files to efl common place because those files in wk1 are in exact accordance with files in wk2, and then delete the files in wk1 and wk2. Looks fine. But, please do line break. This line is too long horizontally. > LayoutTests/ChangeLog:15 > + * platform/efl/fast/text/international/003-expected.txt: Renamed from LayoutTests/platform/efl-wk2/fast/text/international/003-expected.txt. ditto. > LayoutTests/ChangeLog:16 > + * platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt: Renamed from LayoutTests/platform/efl-wk2/fast/text/international/bidi-layout-across-linebreak-expected.txt. ditto.

Sun-woo Nam

Comment 6 2013-11-14 22:38:45 PST

Created attachment 217015 [details] Patch

WebKit Commit Bot

Comment 7 2013-11-15 01:19:40 PST

Comment on attachment 217015 [details] Patch Clearing flags on attachment: 217015 Committed r159329: <http://trac.webkit.org/changeset/159329>

WebKit Commit Bot

Comment 8 2013-11-15 01:19:42 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.