Summary: | Web Inspector: "data detectors" menu on hover for actionable tokens | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||
Component: | Web Inspector | Assignee: | Antoine Quint <graouts> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | 124747 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Antoine Quint
2013-11-14 09:01:48 PST
Right now the color picker is a single click away on the swatch, and we likely can't change that. This will be needed more when we have other popover editors. Created attachment 218448 [details]
Patch
Attachment 218448 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebInspectorUI/ChangeLog', u'Source/WebInspectorUI/UserInterface/HoverMenu.css', u'Source/WebInspectorUI/UserInterface/HoverMenu.js', u'Source/WebInspectorUI/UserInterface/Images/HoverMenuButton.png', u'Source/WebInspectorUI/UserInterface/Images/HoverMenuButton@2x.png', u'Source/WebInspectorUI/UserInterface/Main.html', '--commit-queue']" exit_code: 1 Traceback (most recent call last): File "Tools/Scripts/check-webkit-style", line 48, in <module> sys.exit(CheckWebKitStyle().main()) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/main.py", line 154, in main patch_checker.check(patch) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/patchreader.py", line 71, in check self._text_file_reader.process_file(file_path=path, line_numbers=None) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 118, in process_file lines = self._read_lines(file_path) File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/style/filereader.py", line 86, in _read_lines contents = file.read() File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 671, in read return self.reader.read(size) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/codecs.py", line 477, in read newchars, decodedbytes = self.decode(data, self.errors) UnicodeDecodeError: 'utf8' codec can't decode byte 0x89 in position 0: invalid start byte If any of these errors are false positives, please file a bug against check-webkit-style. Comment on attachment 218448 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218448&action=review > Source/WebInspectorUI/UserInterface/HoverMenu.css:47 > + -webkit-transform: translate3d(-3px, -5px, 0); Does this need to be 3D? Just translate() should work. Maybe I am old school, but negative margin-left and margin-right would work too. > Source/WebInspectorUI/UserInterface/HoverMenu.css:62 > + -webkit-transform: translateX(14px); I'd use margin for this. > Source/WebInspectorUI/UserInterface/HoverMenu.js:46 > + constructor: WebInspector.HoverMenu, > + > + __proto__: WebInspector.Object.prototype, Now blank line. > Source/WebInspectorUI/UserInterface/HoverMenu.js:67 > + setTimeout(function() { > + element.classList.add(WebInspector.HoverMenu.VisibleClassName); > + }); Should explicitly say 0 here. I've also been wanting to use one-off requestAnimationFrame to sync better with the display for things like this. requestAnimationFrame(function() { element.classList.add(WebInspector.HoverMenu.VisibleClassName); }); > Source/WebInspectorUI/UserInterface/HoverMenu.js:69 > + window.addEventListener("scroll", this, true); Do scroll events in overflows bubble? I'm not sure if this will catch any scrolling. Created attachment 218460 [details]
Patch for landing
|