Bug 124362

Summary:

Copy ASAN flag settings to WebCore and JavaScriptCore intermediate build tools

Product:

WebKit

Reporter:

David Farler <dfarler>

Component:

Tools / Tests

Assignee:

David Farler <dfarler>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, mrowe

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

All

Attachments:

Description	Flags
Patch	ddkilzer: review+

Description David Farler 2013-11-14 09:01:27 PST

There is an outstanding bug when using trunk clang that operators new, new[], delete, and delete[] cannot be declared inline. This only shows up when USE_SYSTEM_MALLOC==0 and FastMalloc.h is included. ASAN builds with -DUSE_SYSTEM_MALLOC, so this problem doesn’t normally crop up.

Up to now, the intermediate build tools weren’t built with ASAN because there isn’t a pressing need and it may kill the build. However, ASAN_OPTIONS is set to extremely lenient settings during the build and there haven’t been any false positives in these tools. For better uniformity of the xcconfigs and to avoid any special logic to build some projects without ASAN yet with USE_SYSTEM_MALLOC, I’d like to just use the same C*FLAGS = $(ASAN_C*FLAGS) options that all of the other targets are using to keep the ASAN builds going.

Comment 1 David Farler 2013-11-14 09:20:11 PST

Created attachment 216947 [details]
Patch

Comment 2 David Kilzer (:ddkilzer) 2013-11-15 02:27:53 PST

Comment on attachment 216947 [details]
Patch

r=me

Comment 3 David Farler 2013-11-15 16:08:56 PST

Committed r159369: <http://trac.webkit.org/changeset/159369>