Bug 124335

Summary:

Implement RSASSA-PKCS1-v1_5 sign/verify

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

WebCore Misc.

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

122679

Attachments:

Description	Flags
proposed patch	none
with style fixes	none

Alexey Proskuryakov

Reported 2013-11-13 22:22:21 PST

Implement RSASSA-PKCS1-v1_5 sign/verify

Attachments
proposed patch (57.89 KB, patch) 2013-11-13 22:37 PST, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
with style fixes (57.93 KB, patch) 2013-11-13 23:04 PST, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2013-11-13 22:37:31 PST

Created attachment 216901 [details] proposed patch

WebKit Commit Bot

Comment 2 2013-11-13 22:38:27 PST

Attachment 216901 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5-sign-verify-expected.txt', u'LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5-sign-verify.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp', u'Source/WebCore/crypto/CryptoDigest.h', u'Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA1.cpp', u'Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA224.cpp', u'Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA256.cpp', u'Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA384.cpp', u'Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA512.cpp', u'Source/WebCore/crypto/mac/CryptoAlgorithmSHA1Mac.cpp', u'Source/WebCore/crypto/mac/CryptoAlgorithmSHA224Mac.cpp', u'Source/WebCore/crypto/mac/CryptoAlgorithmSHA256Mac.cpp', u'Source/WebCore/crypto/mac/CryptoAlgorithmSHA384Mac.cpp', u'Source/WebCore/crypto/mac/CryptoAlgorithmSHA512Mac.cpp', u'Source/WebCore/crypto/mac/CryptoDigestMac.cpp']" exit_code: 1 Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:38: Missing spaces around / [whitespace/operators] [3] Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:45: Tab found; better to use spaces [whitespace/tab] [1] Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:45: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:50: Tab found; better to use spaces [whitespace/tab] [1] Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:50: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:51: Tab found; better to use spaces [whitespace/tab] [1] Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:51: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:52: Tab found; better to use spaces [whitespace/tab] [1] Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:52: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:53: Tab found; better to use spaces [whitespace/tab] [1] Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:53: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:54: Tab found; better to use spaces [whitespace/tab] [1] Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:54: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:59: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:91: CryptoAlgorithmRSASSA_PKCS1_v1_5::sign is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:124: One line control clauses should not use braces. [whitespace/braces] [4] Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:130: CryptoAlgorithmRSASSA_PKCS1_v1_5::verify is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 17 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

Alexey Proskuryakov

Comment 3 2013-11-13 23:04:25 PST

Created attachment 216902 [details] with style fixes

WebKit Commit Bot

Comment 4 2013-11-13 23:05:25 PST

Attachment 216902 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5-sign-verify-expected.txt', u'LayoutTests/crypto/subtle/rsassa-pkcs1-v1_5-sign-verify.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp', u'Source/WebCore/crypto/CryptoDigest.h', u'Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA1.cpp', u'Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA224.cpp', u'Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA256.cpp', u'Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA384.cpp', u'Source/WebCore/crypto/algorithms/CryptoAlgorithmSHA512.cpp', u'Source/WebCore/crypto/mac/CryptoAlgorithmSHA1Mac.cpp', u'Source/WebCore/crypto/mac/CryptoAlgorithmSHA224Mac.cpp', u'Source/WebCore/crypto/mac/CryptoAlgorithmSHA256Mac.cpp', u'Source/WebCore/crypto/mac/CryptoAlgorithmSHA384Mac.cpp', u'Source/WebCore/crypto/mac/CryptoAlgorithmSHA512Mac.cpp', u'Source/WebCore/crypto/mac/CryptoDigestMac.cpp']" exit_code: 1 Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:38: Missing spaces around / [whitespace/operators] [3] Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:45: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:50: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:51: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:52: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:53: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:54: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:59: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:91: CryptoAlgorithmRSASSA_PKCS1_v1_5::sign is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WebCore/crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:131: CryptoAlgorithmRSASSA_PKCS1_v1_5::verify is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 10 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 5 2013-11-14 10:24:28 PST

Comment on attachment 216902 [details] with style fixes Clearing flags on attachment: 216902 Committed r159292: <http://trac.webkit.org/changeset/159292>

WebKit Commit Bot

Comment 6 2013-11-14 10:24:30 PST

All reviewed patches have been landed. Closing bug.

Alexey Proskuryakov

Comment 7 2013-11-14 10:59:06 PST

Build fix in <http://trac.webkit.org/r159296>.

Note You need to log in before you can comment on or make changes to this bug.