Deprecate WebHistory methods that use NSCalendarDate

• Component: New Bugs
• Status: REOPENED ---

[Anders Carlsson]

Deprecate WebHistory methods that use NSCalendarDate

[Anders Carlsson]

Created attachment 216886 [details]
Patch

[WebKit Commit Bot]

Attachment 216886 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/ChangeLog', u'Source/WebKit/WebKit.xcodeproj/project.pbxproj', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/History/WebHistory.h', u'Source/WebKit/mac/History/WebHistory.mm']" exit_code: 1
Source/WebKit/mac/History/WebHistory.h:31:  #ifndef header guard has wrong style, please use: WebHistory_h  [build/header_guard] [5]
Source/WebKit/mac/History/WebHistory.h:32:  Missing spaces around =  [whitespace/operators] [4]
Source/WebKit/mac/History/WebHistory.h:32:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Anders Carlsson]

Committed r159271: <http://trac.webkit.org/changeset/159271>

[Joseph Pecoraro]

(In reply to comment #3)
> Committed r159271: <http://trac.webkit.org/changeset/159271>

Rolled this out in <http://trac.webkit.org/changeset/159273> (requested by bdash). It broke Mountain Lion builds:

> CompileC /Volumes/Data/slave/mountainlion-release/build/WebKitBuild/WebKit.build/Release/WebKit.build/Objects-normal/x86_64/WebFrameLoaderClient.o mac/WebCoreSupport/WebFrameLoaderClient.mm normal x86_64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
>     cd /Volumes/Data/slave/mountainlion-release/build/Source/WebKit
>     setenv LANG en_US.US-ASCII
>     /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x objective-c++ -arch x86_64 -fmessage-length=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=gnu++11 -stdlib=libc++ -fobjc-gc -Wno-trigraphs -fno-exceptions -fno-rtti -fpascal-strings -O2 -Werror -Wno-missing-field-initializers -Wmissing-prototypes -Wno-implicit-atomic-properties -Wno-receiver-is-weak -Wno-arc-repeated-use-of-weak -Wnon-virtual-dtor -Wno-overloaded-virtual -Wno-exit-time-destructors -Wduplicate-method-match -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wempty-body -Wuninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wconstant-conversion -Wint-conversion -Wbool-conversion -Wenum-conversion -Wsign-compare -Wno-shorten-64-to-32 -Wnewline-eof -Wno-selector -Wno-strict-selector-match -Wno-undeclared-selector -Wno-deprecated-implementations -Wno-c++11-extensions -DNDEBUG -DENABLE_WEBKIT_UNSET_DYLD_FRAMEWORK_PATH -DENABLE_3D_RENDERING -DENABLE_BLOB -DENABLE_CACHE_PARTITIONING -DENABLE_CANVAS_PATH -DENABLE_CHANNEL_MESSAGING -DENABLE_CSS_BOX_DECORATION_BREAK -DENABLE_CSS_COMPOSITING -DENABLE_CSS_EXCLUSIONS -DENABLE_CSS_FILTERS -DENABLE_CSS_REGIONS -DENABLE_CSS_SHADERS -DENABLE_CSS_SHAPES -DENABLE_CSS_STICKY_POSITION -DENABLE_CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED -DENABLE_CSS3_TEXT_DECORATION -DENABLE_CURSOR_VISIBILITY -DENABLE_DASHBOARD_SUPPORT -DENABLE_DETAILS_ELEMENT -DENABLE_DOM4_EVENTS_CONSTRUCTOR -DENABLE_FILTERS -DENABLE_FULLSCREEN_API -DENABLE_GEOLOCATION -DENABLE_HIDDEN_PAGE_DOM_TIMER_THROTTLING -DENABLE_ICONDATABASE -DENABLE_IFRAME_SEAMLESS -DENABLE_INDEXED_DATABASE -DENABLE_INDIE_UI -DENABLE_INPUT_TYPE_COLOR -DENABLE_INPUT_TYPE_COLOR_POPOVER -DENABLE_JAVASCRIPT_DEBUGGER -DENABLE_LEGACY_CSS_VENDOR_PREFIXES -DENABLE_LEGACY_NOTIFICATIONS -DENABLE_LEGACY_VENDOR_PREFIXES -DENABLE_LEGACY_WEB_AUDIO -DENABLE_MATHML -DENABLE_MEDIA_CONTROLS_SCRIPT -DENABLE_MEDIA_SOURCE -DENABLE_METER_ELEMENT -DENABLE_MOUSE_CURSOR_SCALE -DENABLE_NOTIFICATIONS -DENABLE_PAGE_VISIBILITY_API -DENABLE_PDFKIT_PLUGIN -DENABLE_PROGRESS_ELEMENT -DENABLE_PROMISES -DENABLE_PUBLIC_SUFFIX_LIST -DENABLE_REQUEST_ANIMATION_FRAME -DENABLE_REMOTE_INSPECTOR -DENABLE_SHARED_WORKERS -DENABLE_SPEECH_SYNTHESIS -DENABLE_SQL_DATABASE -DENABLE_SVG -DENABLE_SVG_FONTS -DENABLE_USERSELECT_ALL -DENABLE_VIDEO -DENABLE_VIDEO_TRACK -DENABLE_WEBGL -DENABLE_WEB_ANIMATIONS -DENABLE_WEB_AUDIO -DENABLE_WEB_SOCKETS -DENABLE_WORKERS -DENABLE_XHR_TIMEOUT -DENABLE_XSLT -DFRAMEWORK_NAME=WebKit -DWEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk -fasm-blocks -fstrict-aliasing -Wprotocol -Wdeprecated-declarations -Winvalid-offsetof -mmacosx-version-min=10.8 -g -fvisibility-inlines-hidden -fno-threadsafe-statics -Wno-sign-conversion -I/Volumes/Data/slave/mountainlion-release/build/WebKitBuild/WebKit.build/Release/WebKit.build/WebKit.hmap -I/Volumes/Data/slave/mountainlion-release/build/WebKitBuild/Release/include -I/Volumes/Data/slave/mountainlion-release/build/WebKitBuild/Release/usr/local/include -I/Volumes/Data/slave/mountainlion-release/build/WebKitBuild/Release/WebCore.framework/PrivateHeaders/ForwardingHeaders -I/Volumes/Data/slave/mountainlion-release/build/WebKitBuild/Release/WebCore.framework/PrivateHeaders/icu -I/Volumes/Data/slave/mountainlion-release/build/WebKitBuild/Release/DerivedSources/WebKit -I/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/include -I/Volumes/Data/slave/mountainlion-release/build/WebKitBuild/WebKit.build/Release/WebKit.build/DerivedSources/x86_64 -I/Volumes/Data/slave/mountainlion-release/build/WebKitBuild/WebKit.build/Release/WebKit.build/DerivedSources -Wall -Wextra -Wchar-subscripts -Wextra-tokens -Wformat-security -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wno-unused-parameter -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wexit-time-destructors -Wglobal-constructors -Wtautological-compare -F/Volumes/Data/slave/mountainlion-release/build/WebKitBuild/Release -F/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk/System/Library/Frameworks/WebKit.framework/Versions/A/Frameworks -iframework /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk/System/Library/Frameworks/ApplicationServices.framework/Frameworks -iframework /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk/System/Library/Frameworks/Carbon.framework/Frameworks -iframework /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk/System/Library/Frameworks/Quartz.framework/Frameworks -iframework /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks -iframework /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk/System/Library/PrivateFrameworks -include /Volumes/Data/slave/mountainlion-release/build/WebKitBuild/PrecompiledHeaders/WebKitPrefix-fxwomnyouexnutarzdwigoiniwaf/WebKitPrefix.h -MMD -MT dependencies -MF /Volumes/Data/slave/mountainlion-release/build/WebKitBuild/WebKit.build/Release/WebKit.build/Objects-normal/x86_64/WebFrameLoaderClient.d --serialize-diagnostics /Volumes/Data/slave/mountainlion-release/build/WebKitBuild/WebKit.build/Release/WebKit.build/Objects-normal/x86_64/WebFrameLoaderClient.dia -c /Volumes/Data/slave/mountainlion-release/build/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm -o /Volumes/Data/slave/mountainlion-release/build/WebKitBuild/WebKit.build/Release/WebKit.build/Objects-normal/x86_64/WebFrameLoaderClient.o
> In file included from /Volumes/Data/slave/mountainlion-release/build/Source/WebKit/mac/WebCoreSupport/WebFrameLoaderClient.mm:55:
> In file included from /Volumes/Data/slave/mountainlion-release/build/Source/WebKit/mac/History/WebHistoryInternal.h:29:
> In file included from /Volumes/Data/slave/mountainlion-release/build/Source/WebKit/mac/History/WebHistoryPrivate.h:29:
> /Volumes/Data/slave/mountainlion-release/build/Source/WebKit/mac/History/WebHistory.h:123:36: error: expected ';' after method prototype
> - (NSArray *)orderedLastVisitedDays NS_DEPRECATED_MAC(10_3, 10_9);
>                                    ^
>                                    ;
> /Volumes/Data/slave/mountainlion-release/build/Source/WebKit/mac/History/WebHistory.h:132:103: error: expected ':'
> - (NSArray *)orderedItemsLastVisitedOnDay:(NSCalendarDate *)calendarDate NS_DEPRECATED_MAC(10_3, 10_9);
>                                                                                                       ^
> 2 errors generated.

[Build Bot]

Comment on attachment 216886 [details]
Patch

Attachment 216886 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/22720060

[Build Bot]

Comment on attachment 216886 [details]
Patch

Attachment 216886 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/21250190

[Mark Rowe (bdash)]

Comment on attachment 216886 [details]
Patch

Marking as obsolete since it broke builds.

[Mark Rowe (bdash)]

When we do this we should revert the WebHistory.h portion of r159480 that was added to silence deprecation warnings (<http://trac.webkit.org/changeset/159480/trunk/Source/WebKit/mac/History/WebHistory.h>).