Bug 124307

Summary:

Rename ImmutableArray to API::Array

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, glenn, jer.noble, philn, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	kling: review+

Anders Carlsson

Reported 2013-11-13 13:43:50 PST

Rename ImmutableArray to API::Array

Attachments
Patch (131.58 KB, patch) 2013-11-13 13:48 PST, Anders Carlsson	kling: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2013-11-13 13:48:45 PST

Created attachment 216851 [details] Patch

Andreas Kling

Comment 2 2013-11-13 13:51:00 PST

Comment on attachment 216851 [details] Patch Man, this looks so much better in a separate namespace!

WebKit Commit Bot

Comment 3 2013-11-13 13:51:51 PST

Attachment 216851 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectCoder.mm', u'Source/WebKit2/Shared/API/c/WKArray.cpp', u'Source/WebKit2/Shared/API/c/WKContextMenuItem.cpp', u'Source/WebKit2/Shared/API/c/WKDictionary.cpp', u'Source/WebKit2/Shared/API/c/WKMutableArray.cpp', u'Source/WebKit2/Shared/API/c/WKRenderObject.cpp', u'Source/WebKit2/Shared/API/c/WKSharedAPICast.h', u'Source/WebKit2/Shared/API/c/mac/WKWebArchive.cpp', u'Source/WebKit2/Shared/APIArray.cpp', u'Source/WebKit2/Shared/APIArray.h', u'Source/WebKit2/Shared/Cocoa/WKNSArray.h', u'Source/WebKit2/Shared/Cocoa/WKNSArray.mm', u'Source/WebKit2/Shared/ImmutableArray.cpp', u'Source/WebKit2/Shared/ImmutableArray.h', u'Source/WebKit2/Shared/ImmutableDictionary.cpp', u'Source/WebKit2/Shared/ImmutableDictionary.h', u'Source/WebKit2/Shared/SecurityOriginData.cpp', u'Source/WebKit2/Shared/UserMessageCoders.h', u'Source/WebKit2/Shared/WebArchive.cpp', u'Source/WebKit2/Shared/WebArchive.h', u'Source/WebKit2/Shared/WebContextMenuItem.cpp', u'Source/WebKit2/Shared/WebContextMenuItem.h', u'Source/WebKit2/Shared/WebOpenPanelParameters.cpp', u'Source/WebKit2/Shared/WebOpenPanelParameters.h', u'Source/WebKit2/Shared/WebRenderLayer.cpp', u'Source/WebKit2/Shared/WebRenderLayer.h', u'Source/WebKit2/Shared/WebRenderObject.cpp', u'Source/WebKit2/Shared/WebRenderObject.h', u'Source/WebKit2/UIProcess/API/C/WKBackForwardListRef.cpp', u'Source/WebKit2/UIProcess/API/C/WKOpenPanelParameters.cpp', u'Source/WebKit2/UIProcess/API/C/WKPage.cpp', u'Source/WebKit2/UIProcess/API/C/mac/WKContextPrivateMac.mm', u'Source/WebKit2/UIProcess/API/Cocoa/WKBackForwardList.mm', u'Source/WebKit2/UIProcess/API/mac/WKBrowsingContextGroup.mm', u'Source/WebKit2/UIProcess/Notifications/WebNotificationManagerProxy.cpp', u'Source/WebKit2/UIProcess/Notifications/WebNotificationManagerProxy.h', u'Source/WebKit2/UIProcess/Notifications/WebNotificationProvider.cpp', u'Source/WebKit2/UIProcess/Plugins/PlugInAutoStartProvider.cpp', u'Source/WebKit2/UIProcess/Plugins/PlugInAutoStartProvider.h', u'Source/WebKit2/UIProcess/Plugins/WebPluginSiteDataManager.cpp', u'Source/WebKit2/UIProcess/Plugins/WebPluginSiteDataManager.h', u'Source/WebKit2/UIProcess/StatisticsRequest.cpp', u'Source/WebKit2/UIProcess/WebApplicationCacheManagerProxy.h', u'Source/WebKit2/UIProcess/WebBackForwardList.cpp', u'Source/WebKit2/UIProcess/WebBackForwardList.h', u'Source/WebKit2/UIProcess/WebContext.cpp', u'Source/WebKit2/UIProcess/WebContext.h', u'Source/WebKit2/UIProcess/WebContextClient.cpp', u'Source/WebKit2/UIProcess/WebContextClient.h', u'Source/WebKit2/UIProcess/WebCookieManagerProxy.cpp', u'Source/WebKit2/UIProcess/WebCookieManagerProxy.h', u'Source/WebKit2/UIProcess/WebDatabaseManagerProxy.cpp', u'Source/WebKit2/UIProcess/WebFindClient.cpp', u'Source/WebKit2/UIProcess/WebFindClient.h', u'Source/WebKit2/UIProcess/WebFrameProxy.h', u'Source/WebKit2/UIProcess/WebKeyValueStorageManager.cpp', u'Source/WebKit2/UIProcess/WebKeyValueStorageManager.h', u'Source/WebKit2/UIProcess/WebLoaderClient.cpp', u'Source/WebKit2/UIProcess/WebMediaCacheManagerProxy.cpp', u'Source/WebKit2/UIProcess/WebMediaCacheManagerProxy.h', u'Source/WebKit2/UIProcess/WebOpenPanelResultListenerProxy.cpp', u'Source/WebKit2/UIProcess/WebOpenPanelResultListenerProxy.h', u'Source/WebKit2/UIProcess/WebOriginDataManagerProxy.h', u'Source/WebKit2/UIProcess/WebPageContextMenuClient.cpp', u'Source/WebKit2/UIProcess/WebPageGroup.cpp', u'Source/WebKit2/UIProcess/WebPageGroup.h', u'Source/WebKit2/UIProcess/WebPageProxy.cpp', u'Source/WebKit2/UIProcess/WebPageProxy.h', u'Source/WebKit2/UIProcess/WebResourceCacheManagerProxy.cpp', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleBackForwardListItem.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.h', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.h']" exit_code: 1 Source/WebKit2/UIProcess/API/C/WKPage.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/Shared/API/c/WKSharedAPICast.h:119: More than one command on the same line [whitespace/newline] [4] Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:30: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 4 in 80 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 4 2013-11-13 14:03:03 PST

Committed r159234: <http://trac.webkit.org/changeset/159234>

Note You need to log in before you can comment on or make changes to this bug.