Bug 124295

Summary:

[Cocoa] Add WKNSError

Product:

WebKit

Reporter:

mitz

Component:

WebKit2

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

124327

Bug Blocks:

Attachments:

Description	Flags
Add WKNSError	none

mitz

Reported 2013-11-13 11:13:23 PST

[Cocoa] Add WKNSError

Attachments
Add WKNSError (9.99 KB, patch) 2013-11-13 11:17 PST, mitz	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2013-11-13 11:17:41 PST

Created attachment 216822 [details] Add WKNSError

WebKit Commit Bot

Comment 2 2013-11-13 11:18:36 PST

Attachment 216822 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/Cocoa/APIObject.mm', u'Source/WebKit2/Shared/Cocoa/WKNSError.h', u'Source/WebKit2/Shared/Cocoa/WKNSError.mm', u'Source/WebKit2/WebKit2.xcodeproj/project.pbxproj']" exit_code: 1 Source/WebKit2/Shared/Cocoa/WKNSError.h:34: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 3 2013-11-13 16:47:33 PST

Comment on attachment 216822 [details] Add WKNSError Clearing flags on attachment: 216822 Committed r159263: <http://trac.webkit.org/changeset/159263>

WebKit Commit Bot

Comment 4 2013-11-13 16:47:34 PST

All reviewed patches have been landed. Closing bug.

WebKit Commit Bot

Comment 5 2013-11-13 17:51:09 PST

Re-opened since this is blocked by bug 124327

Note You need to log in before you can comment on or make changes to this bug.