| Summary: | Add support for HTMLMediaElement.fastSeek() | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | buildbot, cdumez, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan, rniwa | ||||||||||||
| Priority: | P2 | ||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Jer Noble
2013-11-12 22:51:07 PST
Created attachment 216769 [details]
Patch
Comment on attachment 216769 [details] Patch Attachment 216769 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/22639943 New failing tests: media/video-fast-seek.html fullscreen/video-controls-timeline.html media/audio-delete-while-slider-thumb-clicked.html media/controls-drag-timebar.html Created attachment 216779 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 216769 [details] Patch Attachment 216769 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/22888965 New failing tests: fullscreen/video-controls-timeline.html media/audio-delete-while-slider-thumb-clicked.html media/controls-drag-timebar.html Created attachment 216784 [details]
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 216808 [details]
Patch
Comment on attachment 216808 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216808&action=review > Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:691 > + // Do a precise seek when we lift the mouse: > + this.video.currentTime = this.controls.timeline.value; Nice! > Source/WebCore/html/HTMLMediaElement.idl:78 > +[RaisesException] void fastSeek(double time); It doesn't look like this (or currentTime) is supposed to throw. > LayoutTests/media/video-fast-seek.html:4 > +<p>Test that fastSeek() commands work correctly > + </p> > +<script src=media-file.js></script> Odd indentation here. It would be nice to stick the <script> in a <head>, include a <!DOCTYPE html>, etc. > LayoutTests/media/video-fast-seek.html:9 > + // The test.mp4 file has sync samples at the following presentation time stamps: > + // 0.0000, 0.7968, 1.5936, 2.3904, 3.1872, 3.9840, 4.7808, 5.5776 This mentions test.mp4, but uses findMediaFile() so other ports could end up with a different file. It may be worth renaming this test and hard coding the test.mp4. (In reply to comment #7) > (From update of attachment 216808 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=216808&action=review > > > Source/WebCore/html/HTMLMediaElement.idl:78 > > +[RaisesException] void fastSeek(double time); > > It doesn't look like this (or currentTime) is supposed to throw. I'll fix this in a future patch. > > LayoutTests/media/video-fast-seek.html:4 > > +<p>Test that fastSeek() commands work correctly > > + </p> > > +<script src=media-file.js></script> > > Odd indentation here. > > It would be nice to stick the <script> in a <head>, include a <!DOCTYPE html>, etc. Fixed and added. > > LayoutTests/media/video-fast-seek.html:9 > > + // The test.mp4 file has sync samples at the following presentation time stamps: > > + // 0.0000, 0.7968, 1.5936, 2.3904, 3.1872, 3.9840, 4.7808, 5.5776 > > This mentions test.mp4, but uses findMediaFile() so other ports could end up with a different file. It may be worth renaming this test and hard coding the test.mp4. Ok. Committed r159208: <http://trac.webkit.org/changeset/159208> Reopening to attach new patch. Created attachment 217087 [details]
Patch
Comment on attachment 217087 [details]
Patch
My mistake.
*** Bug 111983 has been marked as a duplicate of this bug. *** |