Bug 124255

Summary: [GTK][EFL] More on renaming WebKit::APIObject to API::Object
Product: WebKit Reporter: Nick Diego Yamane (diegoyam) <nick.diego>
Component: New BugsAssignee: Nick Diego Yamane (diegoyam) <nick.diego>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cgarcia, cmarcelo, commit-queue, gustavo, gyuyoung.kim, luiz, mrobinson, noam, rakuco, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Rebased Patch none

Nick Diego Yamane (diegoyam)
Reported 2013-11-12 17:49:55 PST
[GTK][EFL] More on renaming WebKit::APIObject to API::Object
Attachments
Patch (20.65 KB, patch)
2013-11-12 17:54 PST, Nick Diego Yamane (diegoyam) 		no flags
DetailsFormatted DiffDiff
Rebased Patch (20.13 KB, patch)
2013-11-12 18:07 PST, Nick Diego Yamane (diegoyam) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nick Diego Yamane (diegoyam)
Comment 1 2013-11-12 17:54:51 PST
Created attachment 216755 [details] Patch
WebKit Commit Bot
Comment 2 2013-11-12 17:56:07 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Commit Bot
Comment 3 2013-11-12 18:02:11 PST
Comment on attachment 216755 [details] Patch Rejecting attachment 216755 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 216755, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: Kit2/UIProcess/soup/WebSoupRequestManagerProxy.h Hunk #1 FAILED at 34. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit2/UIProcess/soup/WebSoupRequestManagerProxy.h.rej patching file Source/WebKit2/WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp patching file Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Tim Horton']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/22779755
Nick Diego Yamane (diegoyam)
Comment 4 2013-11-12 18:07:16 PST
Created attachment 216759 [details] Rebased Patch
WebKit Commit Bot
Comment 5 2013-11-12 18:46:47 PST
Comment on attachment 216759 [details] Rebased Patch Clearing flags on attachment: 216759 Committed r159176: <http://trac.webkit.org/changeset/159176>
WebKit Commit Bot
Comment 6 2013-11-12 18:46:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.