Summary: | Elements with class names automatically get unique ElementData. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||
Component: | DOM | Assignee: | Andreas Kling <kling> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cmarcelo, commit-queue, esprehn+autocc, kangil.han, kling | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Andreas Kling
2013-11-11 22:14:32 PST
Created attachment 216634 [details]
Patch!
Comment on attachment 216634 [details]
Patch!
nice catch
Comment on attachment 216634 [details] Patch! View in context: https://bugs.webkit.org/attachment.cgi?id=216634&action=review > Source/WebCore/dom/Element.cpp:1202 > - const SpaceSplitString oldClasses = ensureUniqueElementData().classNames(); > + // Note: We'll need ElementData, but it doesn't have to be UniqueElementData. > + if (!elementData()) > + ensureUniqueElementData(); Doesn’t this idiom come up anywhere else? I would expect it to be called ensureElementData, except we don’t use the word ensure for this these days, do we? |