Summary: | End of line whitespace should collapse with white-space:pre-wrap; overflow-wrap:break-word in all cases | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Antti Koivisto
2013-11-11 11:15:30 PST
Created attachment 216592 [details]
patch
Attachment 216592 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/text/break-word-pre-wrap-expected.html', u'LayoutTests/fast/text/break-word-pre-wrap.html', u'LayoutTests/platform/mac/fast/forms/basic-textareas-expected.png', u'LayoutTests/platform/mac/fast/forms/basic-textareas-expected.txt', u'LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.png', u'LayoutTests/platform/mac/fast/forms/basic-textareas-quirks-expected.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp']" exit_code: 1
LayoutTests/ChangeLog:14: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 216592 [details]
patch
r=me
Comment on attachment 216592 [details]
patch
r=me
Comment on attachment 216592 [details] patch Attachment 216592 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/22938215 New failing tests: fast/forms/basic-textareas-quirks.html js/basic-set.html fast/forms/basic-textareas.html Created attachment 216596 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 216592 [details] patch Attachment 216592 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/22938228 New failing tests: fast/forms/basic-textareas-quirks.html compositing/tiling/tiled-in-iframe.html fast/forms/basic-textareas.html Created attachment 216604 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
https://trac.webkit.org/r159071 (with sl baselines) Closing the bug as the patch for this bug has been committed in http://trac.webkit.org/changeset/159071. |