Bug 124111

Summary: Move MathML type checking virtuals to RenderObject.
Product: WebKit Reporter: Andreas Kling <kling>
Component: MathMLAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dbarton, dmazzoni, esprehn+autocc, fred.wang, glenn, jcraig, jdiggs, kling, kondapallykalyan, mario, mrobinson, samuel_white
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch andersca: review+

Andreas Kling
Reported 2013-11-09 20:34:25 PST
You currently have to cast renderers to RenderMathMLBlock before you can do further type checking. We should move all those isRenderMathMLFoo() functions to RenderObject.
Attachments
Patch (19.32 KB, patch)
2013-11-09 20:38 PST, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Patch (19.32 KB, patch)
2013-11-09 20:45 PST, Andreas Kling 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-11-09 20:38:18 PST
Created attachment 216508 [details] Patch
Andreas Kling
Comment 2 2013-11-09 20:45:13 PST
Created attachment 216509 [details] Patch Oops, first patch broke accessibility/mathml-elements.html
Andreas Kling
Comment 3 2013-11-09 21:06:49 PST
Committed r159009: <http://trac.webkit.org/changeset/159009>
Note You need to log in before you can comment on or make changes to this bug.