Bug 124110
| Summary: | WebkitGTK Windows not handled headers macro | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Bakhtiar Hasmanan <mr.tiar> |
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | bugs-noreply |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Bakhtiar Hasmanan
I tried to update python binding (pygi) for WebkitGTK 2.2.1
In Source/WTF/wtf/Platform.h
the port trapped in !PLATFORM(QT) asking non existant WTFHeaderDetection
...
#if OS(WINDOWS) && !OS(WINCE)
#define HAVE_SYS_TIMEB_H 1
#define HAVE_ALIGNED_MALLOC 1
#define HAVE_ISDEBUGGERPRESENT 1
#if !PLATFORM(QT)
#include <WTF/WTFHeaderDetection.h>
#endif
#endif
...
I had to add, I change it to #if !PLATFORM(QT) && !PLATFORM(GTK)
In Source/WTF/wtf/atomics.h
mingw combination causes another issues
MemoryBarrier
ReadWriteBarrier
not available in __MINGW32__ but exist in __MINGW64_VERSION_MAJOR
weakCompareAndSwap()
it pick MS-styled asm
In the end I can't generate jscore/webkit gir, I can' run simple gtklauncher too, previously I had to disable JIT but now it throw:
offlineasm: Parsing ./Source/JavaScriptCore/llint/LowLevelInterpreter.asm and Programs/LLIntOffsetsExtractor.exe and creating assembly file DerivedSources/JavaScriptCore/LLIntAssembly.h.
offlineasm: No magic values found. Skipping assembly file generation.
which needed by lowlevel interp
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |