Bug 124088

Summary:

Merge IDBDatabaseBackendInterface and IDBDatabaseBackendImpl

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebCore Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, commit-queue, gyuyoung.kim, jsbell, rakuco

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch v1	thorton: review+, commit-queue: commit-queue-
Patch for landing	none

Brady Eidson

Reported 2013-11-08 17:02:43 PST

Merge IDBDatabaseBackendInterface and IDBDatabaseBackendImpl The abstraction no longer makes any sense in its current form. Some of the groundwork for the DatabaseProcess in WebKit2 relied on this abstraction, but it will be updated in a later patch (It's not used right now, anyways)

Attachments
Patch v1 (178.41 KB, patch) 2013-11-08 17:11 PST, Brady Eidson	thorton: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Patch for landing (178.37 KB, patch) 2013-11-08 21:53 PST, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2013-11-08 17:11:50 PST

Created attachment 216466 [details] Patch v1

WebKit Commit Bot

Comment 2 2013-11-08 19:23:35 PST

Comment on attachment 216466 [details] Patch v1 Rejecting attachment 216466 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 216466, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/22748655

Brady Eidson

Comment 3 2013-11-08 21:53:14 PST

Created attachment 216481 [details] Patch for landing

WebKit Commit Bot

Comment 4 2013-11-08 22:25:26 PST

Comment on attachment 216481 [details] Patch for landing Clearing flags on attachment: 216481 Committed r158992: <http://trac.webkit.org/changeset/158992>

WebKit Commit Bot

Comment 5 2013-11-08 22:25:29 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.