Bug 124082

Summary: Teach CanvasObserver about references
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, gyuyoung.kim, macpherson, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Sam Weinig
Reported 2013-11-08 16:22:16 PST
Teach CanvasObserver about references
Attachments
Patch (8.06 KB, patch)
2013-11-08 16:23 PST, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2013-11-08 16:23:04 PST
Created attachment 216458 [details] Patch
Sam Weinig
Comment 2 2013-11-08 16:25:53 PST
Committed r158972: <http://trac.webkit.org/changeset/158972>
Darin Adler
Comment 3 2013-11-08 16:52:38 PST
Comment on attachment 216458 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216458&action=review > Source/WebCore/css/CSSCanvasValue.h:63 > class CanvasObserverProxy : public CanvasObserver { FINAL? > Source/WebCore/css/CSSCanvasValue.h:65 > + CanvasObserverProxy(CSSCanvasValue& ownerValue) explicit? > Source/WebCore/css/CSSCanvasValue.h:83 > - virtual void canvasDestroyed(HTMLCanvasElement* canvas) > + virtual void canvasChanged(HTMLCanvasElement& canvas, const FloatRect& changedRect) > { > - m_ownerValue->canvasDestroyed(canvas); > + m_ownerValue.canvasChanged(canvas, changedRect); > } > + virtual void canvasResized(HTMLCanvasElement& canvas) > + { > + m_ownerValue.canvasResized(canvas); > + } > + virtual void canvasDestroyed(HTMLCanvasElement& canvas) > + { > + m_ownerValue.canvasDestroyed(canvas); > + } private?
Note You need to log in before you can comment on or make changes to this bug.