Bug 124077

Summary: Merge IDBTransactionBackendInterface and IDBTransactionBackendImpl
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, commit-queue, gyuyoung.kim, jsbell, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch v1 ap: review+

Description Brady Eidson 2013-11-08 15:32:14 PST
Merge IDBTransactionBackendInterface and IDBTransactionBackendImpl

No longer any need for the abstraction
Comment 1 Brady Eidson 2013-11-08 15:35:34 PST
Created attachment 216453 [details]
Patch v1
Comment 2 WebKit Commit Bot 2013-11-08 15:38:05 PST
Attachment 216453 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/indexeddb/IDBBackingStoreInterface.h', u'Source/WebCore/Modules/indexeddb/IDBCursorBackend.cpp', u'Source/WebCore/Modules/indexeddb/IDBCursorBackend.h', u'Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp', u'Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.h', u'Source/WebCore/Modules/indexeddb/IDBFactoryBackendInterface.h', u'Source/WebCore/Modules/indexeddb/IDBTransactionBackend.cpp', u'Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h', u'Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp', u'Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.h', u'Source/WebCore/Modules/indexeddb/IDBTransactionBackendInterface.h', u'Source/WebCore/Modules/indexeddb/IDBTransactionBackendOperations.h', u'Source/WebCore/Modules/indexeddb/IDBTransactionCoordinator.cpp', u'Source/WebCore/Modules/indexeddb/IDBTransactionCoordinator.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp', u'Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h']" exit_code: 1
Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:51:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:52:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:53:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:55:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:60:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:62:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:63:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:71:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:72:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:73:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:74:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:75:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:76:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:77:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:78:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:79:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:80:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:81:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:82:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:84:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Total errors found: 20 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brady Eidson 2013-11-08 15:39:04 PST
(In reply to comment #2)
> Attachment 216453 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Modules/indexeddb/IDBBackingStoreInterface.h', u'Source/WebCore/Modules/indexeddb/IDBCursorBackend.cpp', u'Source/WebCore/Modules/indexeddb/IDBCursorBackend.h', u'Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp', u'Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.h', u'Source/WebCore/Modules/indexeddb/IDBFactoryBackendInterface.h', u'Source/WebCore/Modules/indexeddb/IDBTransactionBackend.cpp', u'Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h', u'Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp', u'Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.h', u'Source/WebCore/Modules/indexeddb/IDBTransactionBackendInterface.h', u'Source/WebCore/Modules/indexeddb/IDBTransactionBackendOperations.h', u'Source/WebCore/Modules/indexeddb/IDBTransactionCoordinator.cpp', u'Source/WebCore/Modules/indexeddb/IDBTransactionCoordinator.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h', u'Source/WebCore/Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp', u'Source/WebCore/Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp', u'Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h']" exit_code: 1
> Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:51:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
> Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:52:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
> Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:53:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
> Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:55:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
> Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:60:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
> Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:62:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
> Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:63:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
> Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:71:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
> Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:72:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
> Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:73:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
> Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:74:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
> Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:75:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
> Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:76:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
> Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:77:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
> Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:78:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
> Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:79:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
> Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:80:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
> Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:81:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
> Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:82:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
> Source/WebCore/Modules/indexeddb/IDBTransactionBackend.h:84:  Extra space before last semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
> Total errors found: 20 in 22 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.


Yikes.  Yep, bad find/replace...  will fix.
Comment 4 Alexey Proskuryakov 2013-11-08 16:05:06 PST
Comment on attachment 216453 [details]
Patch v1 

r=me

Please heed stylebot advice.
Comment 5 Brady Eidson 2013-11-08 16:07:26 PST
http://trac.webkit.org/changeset/158969