|Summary:||[Bugzilla] Add a checkbox to add self to the CC list when creating or editing an attachment|
|Product:||WebKit||Reporter:||Csaba Osztrogonác <ossy>|
|Component:||Tools / Tests||Assignee:||David Kilzer (:ddkilzer) <ddkilzer>|
|Severity:||Normal||CC:||bfulgham, dbates, ddkilzer, lforschler, matthew_hanson, mcatanzaro, ossy, rniwa, thorton|
|Version:||528+ (Nightly build)|
Description Csaba Osztrogonác 2013-11-08 08:47:14 PST
I found an annoying bug in our bugzilla. When I'm not on the cc list of a bug and I review a patch in it, the bugzilla don't cc myself to the bug. It is not good at all, because I won't get any email from this bug if the author fixed what I asked or something wrong happened after landing, ... After a little bit debugging I found it is already fixed in bugzilla, but a little bit later release (4.4) bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=138546 Need email CC addition option on create attachment page Fix: http://bzr.mozilla.org/bugzilla/trunk/revision/8268 I'm going to backport this change to our bugzilla.
Comment 1 Csaba Osztrogonác 2013-11-08 09:53:33 PST
Created attachment 216405 [details] Patch WIP patch, code-review.js change is still needed to let the reviewer edit the addselfcc checkbox. (Otherwise if you review a patch, you will be added to the cc list unconditionally.)
Comment 2 Csaba Osztrogonác 2013-11-08 10:00:37 PST
cc reviewers touched bugzilla code Unfortunately I can't test the patch without local bugzilla setup, but I hope I won't break anything.
Comment 3 Tim Horton 2014-07-14 18:05:31 PDT
I was bit by this twice in a recent week, I think it would be nice to have this fixed. Don't know how to test on a local bugzilla though, sadly.
Comment 4 Csaba Osztrogonác 2016-01-08 00:47:02 PST
*** Bug 152854 has been marked as a duplicate of this bug. ***
Comment 5 Csaba Osztrogonác 2017-03-22 02:02:01 PDT
Bugzilla is already upgraded to 5.0.3: https://lists.webkit.org/pipermail/webkit-dev/2017-March/028882.html The "Details" page already has the addselfcc feature: <input type="checkbox" id="addselfcc" name="addselfcc" checked="checked"> <label for="addselfcc">Add me to CC list</label> We should add the same feature to the "Review patch" page too.
Comment 6 David Kilzer (:ddkilzer) 2017-03-22 11:28:30 PDT
(In reply to Csaba Osztrogonác from comment #0) > After a little bit debugging I found it is already fixed in bugzilla, > but a little bit later release (4.4) > > bug report: > https://bugzilla.mozilla.org/show_bug.cgi?id=138546 > Need email CC addition option on create attachment page > > Fix: > http://bzr.mozilla.org/bugzilla/trunk/revision/8268 https://github.com/bugzilla/bugzilla/commit/5b3ea4d476084d47c99e3d2e9d409fea84c16831
Comment 7 Michael Catanzaro 2017-03-22 11:54:08 PDT
(In reply to Csaba Osztrogonác from comment #0) > I found an annoying bug in our bugzilla. > > When I'm not on the cc list of a bug and I review a patch in it, > the bugzilla don't cc myself to the bug. It is not good at all, > because I won't get any email from this bug if the author fixed > what I asked or something wrong happened after landing, ... I hope making a review using the review form will also auto-CC. I have missed many comments on my reviews due to this issue.
Comment 8 David Kilzer (:ddkilzer) 2017-03-22 13:32:42 PDT
Created attachment 305123 [details] Patch adapted to Bugzilla 5.0.3 Tested on our internal test instance, and this works just as expected.
Comment 9 David Kilzer (:ddkilzer) 2017-03-22 19:02:55 PDT
Created attachment 305154 [details] Patch with fixed paths Same as Attachment 305123 [details], but fixed the paths to apply to the full source tree.
Comment 10 Daniel Bates 2017-03-23 19:42:34 PDT
Comment on attachment 305154 [details] Patch with fixed paths View in context: https://bugs.webkit.org/attachment.cgi?id=305154&action=review > Websites/bugs.webkit.org/ChangeLog:12 > + adds the reviewed to the CC list whether the "Preview" reviewer?