Summary: | [AX] Clean up static_cast<> to cast from AccessibilityObject | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||
Component: | Accessibility | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, mario, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Gyuyoung Kim
2013-11-07 22:51:06 PST
Created attachment 216361 [details]
Patch
Mario, how do you think ? Comment on attachment 216361 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=216361&action=review (In reply to comment #3) > Mario, how do you think ? I think it's a good cleanup. Setting the r+ now, but please fix those small things pointed out below before landing. Thanks! > Source/WebCore/accessibility/AccessibilityListBoxOption.h:65 > - bool isListBoxOption() const { return true; } > + bool isListBoxOption() const OVERRIDE { return true; } You should declare it as virtual and use the FINAL modifier here too if you are declaring this in upper classes as a virtual method (as you are) > Source/WebCore/accessibility/AccessibilitySlider.h:75 > + virtual bool isSliderThumb() const OVERRIDE { return true; } FINAL missing Created attachment 216526 [details]
Patch
(In reply to comment #4) > (From update of attachment 216361 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=216361&action=review > > (In reply to comment #3) > > Mario, how do you think ? > > I think it's a good cleanup. Setting the r+ now, but please fix those small things pointed out below before landing. Thanks! > > > Source/WebCore/accessibility/AccessibilityListBoxOption.h:65 > > - bool isListBoxOption() const { return true; } > > + bool isListBoxOption() const OVERRIDE { return true; } > > You should declare it as virtual and use the FINAL modifier here too if you are declaring this in upper classes as a virtual method (as you are) > > > Source/WebCore/accessibility/AccessibilitySlider.h:75 > > + virtual bool isSliderThumb() const OVERRIDE { return true; } > > FINAL missing Yes, right. Fixed them. Comment on attachment 216526 [details] Patch Clearing flags on attachment: 216526 Committed r159026: <http://trac.webkit.org/changeset/159026> All reviewed patches have been landed. Closing bug. |