Summary: | InlineFlowBox always has a RenderBoxModelObject, take advantage. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||
Component: | Layout and Rendering | Assignee: | Andreas Kling <kling> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kondapallykalyan | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Andreas Kling
2013-11-07 18:03:48 PST
Created attachment 216348 [details]
Patch
Attachment 216348 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/InlineFlowBox.h', u'Source/WebCore/rendering/RenderListItem.cpp', u'Source/WebCore/rendering/RootInlineBox.cpp']" exit_code: 1
Source/WebCore/rendering/InlineFlowBox.cpp:590: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3]
Total errors found: 1 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 216348 [details] Patch Clearing flags on attachment: 216348 Committed r158894: <http://trac.webkit.org/changeset/158894> All reviewed patches have been landed. Closing bug. |