Bug 124006

Summary: returnFromJavaScript() for ARM_THUMB2 uses push()s which should be pop()s
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch for landing none

Michael Saboff
Reported 2013-11-07 11:27:55 PST
returnFromJavaScript() in jit/ThunkGenerators.cpp which is responsible for restoring register state after a call to JavaScript code inadvertently has push() instead of pop() for the ARM_THUMB2 case. This is a copy/paste error from change set r158751: <http://trac.webkit.org/changeset/158751>.
Attachments
Patch for landing (1.80 KB, patch)
2013-11-07 11:30 PST, Michael Saboff 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2013-11-07 11:30:40 PST
Created attachment 216321 [details] Patch for landing This patch has already been reviewed.
Michael Saboff
Comment 2 2013-11-07 11:31:26 PST
Committed r158858: <http://trac.webkit.org/changeset/158858>
Note You need to log in before you can comment on or make changes to this bug.