Bug 124002

Summary: Simple line layout crashes with SVG fonts
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, d-r, esprehn+autocc, fmalita, glenn, gyuyoung.kim, kondapallykalyan, pdr, schenney
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch simon.fraser: review+

Antti Koivisto
Reported 2013-11-07 11:14:11 PST
1 com.apple.WebCore 0x109b9c0e0 WebCore::applyFontTransforms(WebCore::GlyphBuffer*, bool, int&, WebCore::SimpleFontData const*, WebCore::WidthIterator&, unsigned int, WTF::Vector<std::__1::pair<int, WebCore::OriginalAdvancesForCharacterTreatedAsSpace>, 64ul, WTF::CrashOnOverflow>&) + 0xe0 2 com.apple.WebCore 0x109079539 unsigned int WebCore::WidthIterator::advanceInternal<WebCore::Latin1TextIterator>(WebCore::Latin1TextIterator&, WebCore::GlyphBuffer*) + 0xe79 3 com.apple.WebCore 0x108f6b042 WebCore::WidthIterator::advance(int, WebCore::GlyphBuffer*) + 0x52 4 com.apple.WebCore 0x108f6abb5 WebCore::Font::floatWidthForSimpleText(WebCore::TextRun const&, WTF::HashSet<WebCore::SimpleFontData const*, WTF::PtrHash<WebCore::SimpleFontData const*>, WTF::HashTraits<WebCore::SimpleFontData const*> >*, WebCore::GlyphOverflow*) const + 0xe5 5 com.apple.WebCore 0x108f6a815 WebCore::Font::width(WebCore::TextRun const&, WTF::HashSet<WebCore::SimpleFontData const*, WTF::PtrHash<WebCore::SimpleFontData const*>, WTF::HashTraits<WebCore::SimpleFontData const*> >*, WebCore::GlyphOverflow*) const + 0x195 6 com.apple.WebCore 0x10993f57e WebCore::SimpleLineLayout::textWidth(WebCore::RenderText const&, unsigned int, unsigned int, float, WebCore::RenderStyle const&) + 0x18e 7 com.apple.WebCore 0x10993ee9c WebCore::SimpleLineLayout::create(WebCore::RenderBlockFlow&) + 0x46c 8 com.apple.WebCore 0x109bd50a8 WebCore::RenderBlockFlow::layoutSimpleLines(WebCore::LayoutUnit&, WebCore::LayoutUnit&) + 0x28
Attachments
patch (8.90 KB, patch)
2013-11-07 11:21 PST, Antti Koivisto 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-11-07 11:15:06 PST
<rdar://problem/15359245>
Antti Koivisto
Comment 2 2013-11-07 11:21:16 PST
Created attachment 216318 [details] patch
Simon Fraser (smfr)
Comment 3 2013-11-07 11:38:42 PST
Comment on attachment 216318 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=216318&action=review > LayoutTests/fast/text/svg-font-simple-line-crash.html:5 > + testRunner.waitUntilDone(); > + setTimeout(function () { testRunner.notifyDone(); }, 100); Boo.
Antti Koivisto
Comment 4 2013-11-07 11:43:33 PST
http://trac.webkit.org/changeset/158860
Note You need to log in before you can comment on or make changes to this bug.