| Summary: | [CSS Grid Layout] Fix the preferred logical widths code to work with spanning grid items | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sergio Villar Senin <svillar> | ||||
| Component: | CSS | Assignee: | Sergio Villar Senin <svillar> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, darin, dino, esprehn+autocc, glenn, hyatt, jchaffraix, kling, koivisto, kondapallykalyan, svillar | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | 123995, 124345 | ||||||
| Bug Blocks: | 125145 | ||||||
| Attachments: |
|
||||||
Created attachment 217934 [details]
Patch
*** Bug 112388 has been marked as a duplicate of this bug. *** Committed r160633: <http://trac.webkit.org/changeset/160633> |
We should merge: Fix the preferred logical widths code to work with spanning grid items We implemented a simple algorithm to get the easy cases. The algorithm was completely wrong for more complex cases though, which was fine as the specification was completely silent on how to compute these logical widths. This has been raised to the working group in http://lists.w3.org/Archives/Public/www-style/2013Oct/0054.html No one objected after a week so we should be good to go. BUG=234197 Review URL: https://codereview.chromium.org/26557002