Bug 123994

Summary: [CSS Grid Layout] Fix the preferred logical widths code to work with spanning grid items
Product: WebKit Reporter: Sergio Villar Senin <svillar>
Component: CSSAssignee: Sergio Villar Senin <svillar>
Severity: Normal CC: commit-queue, darin, dino, esprehn+autocc, glenn, hyatt, jchaffraix, kling, koivisto, kondapallykalyan, svillar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 123995, 124345    
Bug Blocks: 125145    
Description Flags
Patch kling: review+

Description Sergio Villar Senin 2013-11-07 07:58:50 PST
We should merge:

    Fix the preferred logical widths code to work with spanning grid items

    We implemented a simple algorithm to get the easy cases. The
    algorithm was completely wrong for more complex cases though,
    which was fine as the specification was completely silent on
    how to compute these logical widths. This has been raised to
    the working group in
    No one objected after a week so we should be good to go.
    Review URL: https://codereview.chromium.org/26557002
Comment 1 Sergio Villar Senin 2013-11-27 03:09:08 PST
Created attachment 217934 [details]
Comment 2 Sergio Villar Senin 2013-11-28 00:25:13 PST
*** Bug 112388 has been marked as a duplicate of this bug. ***
Comment 3 Sergio Villar Senin 2013-12-16 04:05:29 PST
Committed r160633: <http://trac.webkit.org/changeset/160633>