Bug 123981

Summary: [GTK] Move baselines after r158742 into proper place
Product: WebKit Reporter: Krzysztof Czech <k.czech>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jdiggs, mario, samuel_white
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Krzysztof Czech
Reported 2013-11-07 03:01:14 PST
r158742 added files to platform/gtk-wk1/accessibility/ which was wrong. Correcting this by moving them to platform/gtk/accessibility.
Attachments
patch (55.25 KB, patch)
2013-11-07 03:07 PST, Krzysztof Czech 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Krzysztof Czech
Comment 1 2013-11-07 03:07:13 PST
Created attachment 216282 [details] patch
Mario Sanchez Prada
Comment 2 2013-11-07 03:09:02 PST
Comment on attachment 216282 [details] patch (In reply to comment #0) > r158742 added files to platform/gtk-wk1/accessibility/ which was wrong. > Correcting this by moving them to platform/gtk/accessibility. Now problem, after all I haven't realized of it either. Thanks for taking care of getting it back to the original state
Mario Sanchez Prada
Comment 3 2013-11-07 03:23:48 PST
Comment on attachment 216282 [details] patch Hmm.. it seems the quilty commit was r158810, as a result of running "webkit-patch optimize-baselines accessibility". Setting cq- for not, need to double check this better...
Mario Sanchez Prada
Comment 4 2013-11-07 05:45:36 PST
Comment on attachment 216282 [details] patch (In reply to comment #3) > (From update of attachment 216282 [details]) > Hmm.. it seems the quilty commit was r158810, as a result of running "webkit-? > patch optimize-baselines accessibility". Setting cq- for not, need to double > check this better... It was a bit confusing but after some investigation I understand what happened: the "optimize baselines" command just move expectations around to make their storage more efficient but, unluckily enough, those two tests related two tables also got at almost the same time in the state of "needing rebaseline". So that's why they were failing in the bots: not because of their wrong location but because neither the expectations in gtk-wk1/ nor the ones in gtk-wk2/ were correct at this point. Fortunately, they are correct anyway and, even better, exactly the same among the two versions of the port, so the right solution is to generate new expectations, place them together under gtk/ again and remove the specific ones we used to have in gtk-wk2. So, clearing flags for now
Mario Sanchez Prada
Comment 5 2013-11-07 05:46:17 PST
(In reply to comment #4) > [...] so the right solution is to generate new expectations, place them > together under gtk/ again and remove the specific ones we used to have > in gtk-wk2. > Done in SVN r158847: http://trac.webkit.org/changeset/158847
Note You need to log in before you can comment on or make changes to this bug.