Bug 123975

Summary: Crash when submitting form in a document with null encoding
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: FormsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, beidson, benjamin, commit-queue, darin, jonlee, mitz, webkit-bug-importer
Priority: P2 Keywords: BlinkMergeCandidate, InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug none

Ryosuke Niwa
Reported 2013-11-07 01:25:40 PST
Merge https://chromium.googlesource.com/chromium/blink/+/bba01a7fff09e3053ada96ababac2a6e4261fe5f The CString object which is passed to normalizeLineEndingsToCRLF() can be a null string. It is created in FormDataList::appendString(), and it produces a null CString if FormDataList::m_encoding is a null encoding.
Attachments
Fixes the bug (3.75 KB, patch)
2013-11-07 01:30 PST, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-11-07 01:28:44 PST
The crash reproduces on Safari & nightly builds of WebKit.
Radar WebKit Bug Importer
Comment 2 2013-11-07 01:29:49 PST
<rdar://problem/15412395>
Ryosuke Niwa
Comment 3 2013-11-07 01:30:38 PST
Created attachment 216275 [details] Fixes the bug
Alexey Proskuryakov
Comment 4 2013-11-07 09:34:19 PST
Comment on attachment 216275 [details] Fixes the bug lol
Ryosuke Niwa
Comment 5 2013-11-07 13:12:02 PST
(In reply to comment #4) > (From update of attachment 216275 [details]) > lol That's what I said too!
WebKit Commit Bot
Comment 6 2013-11-07 13:37:50 PST
Comment on attachment 216275 [details] Fixes the bug Clearing flags on attachment: 216275 Committed r158868: <http://trac.webkit.org/changeset/158868>
WebKit Commit Bot
Comment 7 2013-11-07 13:37:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.