Bug 123971

Summary: Jhbuild build bug workaround
Product: WebKit Reporter: Przemyslaw Szymanski <p.szymanski3>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
jhbuild fix none

Description Przemyslaw Szymanski 2013-11-07 00:46:54 PST 
Jhbuild build uses Makefile.plain lcated in po directory (WebKitBuild/Dependencies/Source/jhbuild/po). This makefile file uses grep -v '^\#' LINGUAS
Output from this grep is:

ca
cs
de
el
en_GB
(...)

If someone has set grep env variable GREP_OPTIONS=-n (or other that changes grep output) then this output will be:

2:ca
3:cs
4:de
5:el
6:en_GB
(...)

The line is added by grep.
After that jhbuild will not build because this grep output is different than expected.
If you will try to build jhbuild (make install) with this grep option output will be:

make[1]: Entering directory `WebKit/WebKitBuild/Dependencies/Source/jhbuild/po'
Makefile.plain:10: *** target pattern contains no `%'.  Stop.
make[1]: Leaving directory `WebKit/WebKitBuild/Dependencies/Source/jhbuild/po'
make: *** [install] Error 2

This patch is a WebKit workaround to this jhbuild issue. It doesn't changes anything else with WebKit build.
Comment 1 Przemyslaw Szymanski 2013-11-07 00:49:10 PST 
Created attachment 216270 [details]
jhbuild fix
Comment 2 Ryosuke Niwa 2013-11-07 01:00:35 PST 
Comment on attachment 216270 [details]
jhbuild fix

rs=me.
Comment 3 Przemyslaw Szymanski 2013-11-08 01:15:49 PST 
(In reply to comment #2)
> (From update of attachment 216270 [details])
> rs=me.

Thank you for review.
cq?
Comment 4 WebKit Commit Bot 2013-11-08 01:41:44 PST 
Comment on attachment 216270 [details]
jhbuild fix

Clearing flags on attachment: 216270

Committed r158912: <http://trac.webkit.org/changeset/158912>
Comment 5 WebKit Commit Bot 2013-11-08 01:41:46 PST 
All reviewed patches have been landed.  Closing bug.