Bug 123949

Summary: Hoist <template> to head when found between </head> and <body> for consistency with <script>
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, benjamin, commit-queue, esprehn+autocc, gyuyoung.kim, kling, koivisto, sam
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 123851    
Attachments:
Description Flags
Patch
none
Tweaked the change log a little
none
Patch for landing none

Comment 1 Ryosuke Niwa 2013-11-20 01:06:01 PST 
Created attachment 217402 [details]
Patch
Comment 2 Ryosuke Niwa 2013-11-20 01:07:29 PST 
Created attachment 217404 [details]
Tweaked the change log a little
Comment 3 Antti Koivisto 2013-11-20 16:46:25 PST 
Comment on attachment 217404 [details]
Tweaked the change log a little

View in context: https://bugs.webkit.org/attachment.cgi?id=217404&action=review

> Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1644
> +#if ENABLE(TEMPLATE_ELEMENT)
> +            if (isParsingFragment())
> +#else
> +            ASSERT(isParsingFragment());
> +#endif
> +                item = HTMLStackItem::create(m_fragmentContext.contextElement(), HTMLStackItem::ItemForContextElement);

This is somewhat ugly. It is nicer to do something like this:

#if ENABLE(TEMPLATE_ELEMENT)
bool shouldCreateItem = isParsingFragment();
#else
ASSERT(isParsingFragment());
bool shouldCreateItem = true;
#endif
if (shouldCreateItem) ...
Comment 4 Ryosuke Niwa 2013-11-20 22:22:54 PST 
(In reply to comment #3)
>
> This is somewhat ugly. It is nicer to do something like this:
> 
> #if ENABLE(TEMPLATE_ELEMENT)
> bool shouldCreateItem = isParsingFragment();
> #else
> ASSERT(isParsingFragment());
> bool shouldCreateItem = true;
> #endif
> if (shouldCreateItem) ...

Makes sense. Done that.
Comment 5 Ryosuke Niwa 2013-11-20 22:27:48 PST 
Created attachment 217519 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2013-11-20 22:57:45 PST 
Comment on attachment 217519 [details]
Patch for landing

Clearing flags on attachment: 217519

Committed r159610: <http://trac.webkit.org/changeset/159610>
Comment 7 WebKit Commit Bot 2013-11-20 22:57:48 PST 
All reviewed patches have been landed.  Closing bug.