Bug 123928

Summary: Cleanup FontMac.mm
Product: WebKit Reporter: Daniel Bates <dbates>
Component: PlatformAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch aestes: review+

Daniel Bates
Reported 2013-11-06 14:20:54 PST
We should remove the default case statement from the switch block in Font::drawGlyphs(), <http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/mac/FontMac.mm?rev=158581#L143>, so that the compiler enforces that the switch covers all cases. We should inline the definition of isVertical in showGlyphsWithAdvances() since its referenced exactly once and its value is sufficiently clear. Additionally, we should use the variable platformData throughout Font::drawGlyphs() instead of using the variable in some place and explicitly querying for the Font's platform data in others.
Attachments
Patch (3.86 KB, patch)
2013-11-06 14:22 PST, Daniel Bates 		aestes: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2013-11-06 14:22:00 PST
Created attachment 216226 [details] Patch
Daniel Bates
Comment 2 2013-11-06 15:58:22 PST
Committed r158800: <http://trac.webkit.org/changeset/158800>
Note You need to log in before you can comment on or make changes to this bug.