Bug 123901
Summary: | [GStreamer] Implement "id" property for in-band audio, text and video tracks | ||
---|---|---|---|
Product: | WebKit | Reporter: | Brendan Long <b.long> |
Component: | Media | Assignee: | Philippe Normand <philn> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | bugs-noreply, pnormand, webkit-bug-importer |
Priority: | P2 | Keywords: | InRadar |
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=162869 |
Brendan Long
TextTrack: http://www.w3.org/TR/html5/embedded-content-0.html#dom-texttrack-id
> The id attribute returns the track's identifier, if it has one, or the empty string otherwise. For tracks that correspond to track elements, the track's identifier is the value of the element's id attribute, if any. For in-band tracks, the track's identifier is specified by the media resource. If the media resource is in a format that supports the Media Fragments URI fragment identifier syntax, the identifier returned for a particular track must be the same identifier that would enable the track if used as the name of a track in the track dimension of such a fragment identifier.
AudioTrack and VideoTrack: http://www.w3.org/TR/html5/embedded-content-0.html#dom-audiotrack-id
> The AudioTrack.id and VideoTrack.id attributes must return the identifier of the track, if it has one, or the empty string otherwise. If the media resource is in a format that supports the Media Fragments URI fragment identifier syntax, the identifier returned for a particular track must be the same identifier that would enable the track if used as the name of a track in the track dimension of such a fragment identifier.
The only example given is that for Ogg Skeleton, the "id" is the name:
https://wiki.xiph.org/SkeletonHeaders#Name
I'm planning to implement this as:
* Matroska / WebM: TrackUID
* MPEG-TS: PID
* Ogg (without Skeleton): Stream serial number
Unfortunately this needs some work on the GStreamer side to make that information available:
https://bugzilla.gnome.org/show_bug.cgi?id=711522
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Philippe Normand
Pull request: https://github.com/WebKit/WebKit/pull/24248
EWS
Committed 274623@main (cb24c51631e8): <https://commits.webkit.org/274623@main>
Reviewed commits have been landed. Closing PR #24248 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/122939833>