Summary: | [GTK] Pass the library namespace to gtkdoc-mkdb | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | gustavo, mrobinson | ||||||
Priority: | P2 | Keywords: | Gtk | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2013-11-06 10:02:15 PST
Created attachment 216188 [details]
Patch
Comment on attachment 216188 [details]
Patch
Looks good, but perhaps the name of the argument should be namespace instead of name_space/name-space, since the word itself is 'namespace'?
(In reply to comment #2) > (From update of attachment 216188 [details]) > Looks good, but perhaps the name of the argument should be namespace instead of name_space/name-space, since the word itself is 'namespace'? It makes sense yes, I followed the gtk-doc argument which is name-space. I'll change it. Created attachment 216295 [details]
Updated patch
Use namespace.
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 216188 [details] [details]) > > Looks good, but perhaps the name of the argument should be namespace instead of name_space/name-space, since the word itself is 'namespace'? > > It makes sense yes, I followed the gtk-doc argument which is name-space. I'll change it. Oh! Didn't notice that. Another quirk of gtkdoc. Committed r158908: <http://trac.webkit.org/changeset/158908> |