Bug 123900

Summary: [GTK] Pass the library namespace to gtkdoc-mkdb
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, mrobinson
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Updated patch mrobinson: review+

Description Carlos Garcia Campos 2013-11-06 10:02:15 PST
This fixes the generation of the index of symbols in the API documentation. We are currently generating a single entry for all symbols starting with W (all of them), see for example:

http://webkitgtk.org/reference/webkitgtk/unstable/index-all.html
Comment 1 Carlos Garcia Campos 2013-11-06 10:05:02 PST
Created attachment 216188 [details]
Patch
Comment 2 Martin Robinson 2013-11-06 10:08:03 PST
Comment on attachment 216188 [details]
Patch

Looks good, but perhaps the name of the argument should be namespace instead of name_space/name-space, since the word itself is 'namespace'?
Comment 3 Carlos Garcia Campos 2013-11-06 23:29:17 PST
(In reply to comment #2)
> (From update of attachment 216188 [details])
> Looks good, but perhaps the name of the argument should be namespace instead of name_space/name-space, since the word itself is 'namespace'?

It makes sense yes, I followed the gtk-doc argument which is name-space. I'll change it.
Comment 4 Carlos Garcia Campos 2013-11-07 05:20:48 PST
Created attachment 216295 [details]
Updated patch

Use namespace.
Comment 5 Martin Robinson 2013-11-07 08:06:31 PST
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 216188 [details] [details])
> > Looks good, but perhaps the name of the argument should be namespace instead of name_space/name-space, since the word itself is 'namespace'?
> 
> It makes sense yes, I followed the gtk-doc argument which is name-space. I'll change it.

Oh! Didn't notice that. Another quirk of gtkdoc.
Comment 6 Carlos Garcia Campos 2013-11-08 00:10:17 PST
Committed r158908: <http://trac.webkit.org/changeset/158908>