Bug 123894

Summary:

AX: [ATK] Video and audio elements are not properly exposed

Product:

WebKit

Reporter:

Mario Sanchez Prada <mario>

Component:

Accessibility

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, cdumez, cfleizach, commit-queue, dmazzoni, eric.carlson, glenn, gyuyoung.kim, jcraig, jdiggs, jer.noble, rakuco, samuel_white, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch proposal	cfleizach: review+

Description Mario Sanchez Prada 2013-11-06 08:28:09 PST

They should be exposed for now as ATK_ROLE_EMBEDDED, although later on they will probably should be updated to be exposed with a more media-ish role, once it exists in ATK (https://bugzilla.gnome.org/show_bug.cgi?id=711558).

This would help to pass properly the following failing tests:

accessibility/media-element.html
platform/gtk/accessibility/media-controls-panel-title.html

Comment 1 Radar WebKit Bug Importer 2013-11-06 08:28:36 PST

<rdar://problem/15404002>

Comment 2 Mario Sanchez Prada 2013-11-06 09:53:51 PST

Created attachment 216187 [details]
Patch proposal

Comment 3 chris fleizach 2013-11-06 10:50:02 PST

Comment on attachment 216187 [details]
Patch proposal

View in context: https://bugs.webkit.org/attachment.cgi?id=216187&action=review

> LayoutTests/platform/efl/accessibility/media-emits-object-replacement.html:6
> +  var str = "";

need more indentation (4 spaces instead of 2)

> LayoutTests/platform/gtk/accessibility/media-emits-object-replacement.html:20
> +      return false;

need more indentation for this block of code in this function

> LayoutTests/platform/gtk/accessibility/media-emits-object-replacement.html:55
> +  buildAccessibilityTree(accessibilityController.focusedElement, 0);

need more indentation for these two lines

Comment 4 Mario Sanchez Prada 2013-11-07 03:10:34 PST

Committed r158841: <http://trac.webkit.org/changeset/158841>