Bug 123892

Summary:

[Win] Link fails.

Product:

WebKit

Reporter:

peavo

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, esprehn+autocc, glenn, kondapallykalyan

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Unspecified

Attachments:

Description	Flags
Patch	bfulgham: review+, commit-queue: commit-queue-

peavo

Reported 2013-11-06 07:15:37 PST

Today's WinCairo build fails with these linker errors: WebCore.lib(RenderingAllInOne.obj) : error LNK2001: unresolved external symbol "public: virtual void __thiscall WebCore::InlineElementBox::deleteLine(void)" (?deleteLine@InlineElementBox@WebCore@@UAEXXZ) WebCore.lib(RenderingAllInOne.obj) : error LNK2001: unresolved external symbol "public: virtual void __thiscall WebCore::InlineElementBox::extractLine(void)" (?extractLine@InlineElementBox@WebCore@@UAEXXZ) WebCore.lib(RenderingAllInOne.obj) : error LNK2001: unresolved external symbol "public: virtual void __thiscall WebCore::InlineElementBox::attachLine(void)" (?attachLine@InlineElementBox@WebCore@@UAEXXZ)

Attachments
Patch (1.07 KB, patch) 2013-11-06 07:18 PST, peavo	bfulgham: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

peavo

Comment 1 2013-11-06 07:18:57 PST

Created attachment 216173 [details] Patch

Brent Fulgham

Comment 2 2013-11-06 09:03:22 PST

Comment on attachment 216173 [details] Patch r=me. Thanks for fixing this!

WebKit Commit Bot

Comment 3 2013-11-06 09:04:55 PST

Comment on attachment 216173 [details] Patch Rejecting attachment 216173 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 216173, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: am']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/rendering/RenderingAllInOne.cpp Hunk #1 FAILED at 37. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/rendering/RenderingAllInOne.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Brent Fulgham']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/22028004

peavo

Comment 4 2013-11-06 09:35:44 PST

(In reply to comment #2) > (From update of attachment 216173 [details]) > r=me. Thanks for fixing this! Thanks for reviewing, already fixed by r158749, it seems :)

Brent Fulgham

Comment 5 2013-11-06 09:45:24 PST

Fixed by r158749

Note You need to log in before you can comment on or make changes to this bug.