Summary: | AX: [ATK] <span> elements exposed through ATK when not needed | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mario Sanchez Prada <mario> | ||||||||
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, eflews.bot, gtk-ews, gyuyoung.kim, jcraig, jdiggs, k.czech, rego+ews, samuel_white, webkit-bug-importer, xan.lopez | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Mario Sanchez Prada
2013-11-06 03:10:13 PST
Created attachment 216177 [details]
Patch proposal
Comment on attachment 216177 [details] Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=216177&action=review > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1925 > + can all these checks move into AccessibilityObject? > Source/WebCore/accessibility/AccessibilityObject.h:608 > + virtual bool hasAccessibleName() const; I think this should be called something like hasAccessibleAttributes() or hasRequiredInclusionAttributes() or hasAttributedRequiredForInclusion() something to denote that this method should be used to determine whether to include it in the tree Comment on attachment 216177 [details] Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=216177&action=review >> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1925 >> + > > can all these checks move into AccessibilityObject? Hmm... yes and no: we can move the MathML part but not the ariaAccessibilityDescription() call since that's a non-virtual method from AccessibilityNodeObject. >> Source/WebCore/accessibility/AccessibilityObject.h:608 >> + virtual bool hasAccessibleName() const; > > I think this should be called something like hasAccessibleAttributes() or hasRequiredInclusionAttributes() or hasAttributedRequiredForInclusion() > > something to denote that this method should be used to determine whether to include it in the tree Believe it or not, I struggled to find a name for this and in the end this is the least bad I found. hasAttributedRequiredForInclusion() sounds good to me, though (In reply to comment #4) > (From update of attachment 216177 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=216177&action=review > > >> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1925 > >> + > > > > can all these checks move into AccessibilityObject? > > Hmm... yes and no: we can move the MathML part but not the ariaAccessibilityDescription() call since that's a non-virtual method from AccessibilityNodeObject. > > >> Source/WebCore/accessibility/AccessibilityObject.h:608 > >> + virtual bool hasAccessibleName() const; > > > > I think this should be called something like hasAccessibleAttributes() or hasRequiredInclusionAttributes() or hasAttributedRequiredForInclusion() > > > > something to denote that this method should be used to determine whether to include it in the tree > > Believe it or not, I struggled to find a name for this and in the end this is the least bad I found. > > hasAttributedRequiredForInclusion() sounds good to me, though should be: hasAttributesRequiredForInclusion() Created attachment 216298 [details] Patch proposal (In reply to comment #5) > [...] > should be: hasAttributesRequiredForInclusion() New patch attached renaming that function and moving the MathML bits up into AccessibilityObject Comment on attachment 216298 [details] Patch proposal Attachment 216298 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/21248312 Comment on attachment 216298 [details] Patch proposal Attachment 216298 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/22738203 Comment on attachment 216298 [details] Patch proposal Attachment 216298 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/22718202 Created attachment 216299 [details]
Patch proposal
Committed r158914: <http://trac.webkit.org/changeset/158914> |