Bug 123884

Summary: [ATK] accessibility/tabindex-elements-are-accessible.html is failing
Product: WebKit Reporter: Krzysztof Czech <k.czech>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, a.moryc, apinheiro, cdumez, cfleizach, commit-queue, dmazzoni, gyuyoung.kim, jcraig, jdiggs, lucas.de.marchi, mario, rakuco, samuel_white
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch none

Description Krzysztof Czech 2013-11-06 02:07:32 PST
I think we should generate a new expectation for GTK, EFL. It seems ATK represents paragraph's role as a ATK_ROLE_PARAGRAPH => AXParagraph. On MAC it's a AXGroup.
Comment 1 Krzysztof Czech 2013-11-06 02:19:48 PST
Created attachment 216157 [details]
patch
Comment 2 Krzysztof Czech 2013-11-06 02:27:52 PST
Created attachment 216158 [details]
patch
Comment 3 Krzysztof Czech 2013-11-06 02:30:10 PST
I'm attaching a buildbot log:
--- /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/layout-test-results/accessibility/tabindex-elements-are-accessible-expected.txt
+++ /mnt/buildbot/efl-linux-slave-2/efl-linux-64-release-wk2/build/layout-test-results/accessibility/tabindex-elements-are-accessible-actual.txt
@@ -19,7 +19,7 @@


 Item 4: Is focusable: true
-Item 4: AXRole: AXGroup
+Item 4: AXRole: AXParagraph


 PASS successfullyParsed is true
Comment 4 Artur Moryc 2013-11-06 02:31:24 PST
*** Bug 123738 has been marked as a duplicate of this bug. ***
Comment 5 Mario Sanchez Prada 2013-11-06 03:04:00 PST
Comment on attachment 216158 [details]
patch

(In reply to comment #0)
> I think we should generate a new expectation for GTK, EFL. It seems ATK
> represents paragraph's role as a ATK_ROLE_PARAGRAPH => AXParagraph. On MAC
> it's a AXGroup.

Yes, that's right. There's another issue provoked by the patch that introduced this new layout test, but it's completely unrelated to it (I started working on that and will file a bug soon), so I'm ok with this specific fix now.
Comment 6 WebKit Commit Bot 2013-11-06 03:29:17 PST
Comment on attachment 216158 [details]
patch

Clearing flags on attachment: 216158

Committed r158741: <http://trac.webkit.org/changeset/158741>
Comment 7 WebKit Commit Bot 2013-11-06 03:29:21 PST
All reviewed patches have been landed.  Closing bug.