Bug 123882 – Add InlineElementBox and stop instantiating InlineBox directly.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Andreas Kling]

Add InlineElementBox and stop instantiating InlineBox directly.

[Andreas Kling]

Created attachment 216155 [details]
Patch

[WebKit Commit Bot]

Attachment 216155 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/rendering/EllipsisBox.cpp', u'Source/WebCore/rendering/EllipsisBox.h', u'Source/WebCore/rendering/InlineBox.cpp', u'Source/WebCore/rendering/InlineBox.h', u'Source/WebCore/rendering/InlineElementBox.cpp', u'Source/WebCore/rendering/InlineElementBox.h', u'Source/WebCore/rendering/InlineFlowBox.h', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderLineBreak.cpp']" exit_code: 1
Source/WebCore/rendering/InlineBox.h:376:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/InlineElementBox.cpp:63:  Could not find a newline character at the end of the file.  [whitespace/ending_newline] [5]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Antti Koivisto]

Comment on attachment 216155 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=216155&action=review

> Source/WebCore/rendering/InlineFlowBox.h:41
> -class InlineFlowBox : public InlineBox {
> +class InlineFlowBox : public InlineElementBox {

I'm not sure if this inheritance is useful. Is there some useful code sharing possible with this?

[Andreas Kling]

Committed r158736: <http://trac.webkit.org/changeset/158736>